Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVF-Flat: fix search batching #1764

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented Aug 23, 2023

Fix the cluster probes (coarse_index) not being advanced when batching.

Thanks @tarang-jain for the precise reproducer.

Closes: #1756

@achirkin achirkin requested a review from a team as a code owner August 23, 2023 09:48
@github-actions github-actions bot added the cpp label Aug 23, 2023
@achirkin achirkin added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Aug 23, 2023
@cjnolet
Copy link
Member

cjnolet commented Aug 23, 2023

LGTM. Thanks for fixing this so quickly @achirkin!

@cjnolet
Copy link
Member

cjnolet commented Aug 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9019054 into rapidsai:branch-23.10 Aug 23, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Inaccuracy in IVF-Flat Search Results with Large Number of Queries
2 participants