Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Migrating cuml comms to raft::comms #7

Merged
merged 51 commits into from
Jun 3, 2020
Merged

[REVIEW] Migrating cuml comms to raft::comms #7

merged 51 commits into from
Jun 3, 2020

Commits on May 7, 2020

  1. Initial commit of raft comms

    @cjnolet
    cjnolet committed May 7, 2020
    Configuration menu
    Copy the full SHA
    fd38dbb View commit details
    Browse the repository at this point in the history

  2. Removing cuml verbiage

    @cjnolet
    cjnolet committed May 7, 2020
    Configuration menu
    Copy the full SHA
    8a6e054 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Renaming to comms_t, removing logs for now, adding to handle

    @cjnolet
    cjnolet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    2bfc0dc View commit details
    Browse the repository at this point in the history

  2. Looking like it's building!

    @cjnolet
    cjnolet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    f129710 View commit details
    Browse the repository at this point in the history

  3. Adding NCCL and UCX build for tests

    @cjnolet
    cjnolet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    a0c13af View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fea-ext-migrate-cumlHandle_impl-into-raft' into fea-ext… 

    …-comms

Conflicts:
	cpp/include/raft/handle.hpp
    @cjnolet
    cjnolet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    7ad2053 View commit details
    Browse the repository at this point in the history

  5. Consolidating injection functions

    @cjnolet
    cjnolet committed May 8, 2020
    Configuration menu
    Copy the full SHA
    cb19482 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Merge branch 'fea-ext-migrate-cumlHandle_impl-into-raft' into fea-ext… 

    …-comms

Conflicts:
	cpp/include/raft/handle.hpp
    @cjnolet
    cjnolet committed May 12, 2020
    Configuration menu
    Copy the full SHA
    1d66637 View commit details
    Browse the repository at this point in the history

  2. Making progress on Python. Need to refactor the comms interface a lit… 

    …tle bit
    @cjnolet
    cjnolet committed May 12, 2020
    Configuration menu
    Copy the full SHA
    1548177 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Cython is building!

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    5d37e9e View commit details
    Browse the repository at this point in the history

  2. The comms tests pass!!!

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    bd1b876 View commit details
    Browse the repository at this point in the history

  3. Fixing flake8 style

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    98496d3 View commit details
    Browse the repository at this point in the history

  4. Running clang format and removing getDataType

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fb52f79 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'github/branch-0.14' into fea-ext-comms

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d666314 View commit details
    Browse the repository at this point in the history

  6. Cleaning up

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    46a27eb View commit details
    Browse the repository at this point in the history

  7. Fixing python style

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fc6ba2e View commit details
    Browse the repository at this point in the history

  8. Fixing cpp style

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    842f533 View commit details
    Browse the repository at this point in the history

  9. Adding copyright headers

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    43f0d69 View commit details
    Browse the repository at this point in the history

  10. Adding init py for tests

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ac6e699 View commit details
    Browse the repository at this point in the history

  11. Adding license headers and consistent namespacing

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c442d87 View commit details
    Browse the repository at this point in the history

  12. More cleanup

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    32e63c1 View commit details
    Browse the repository at this point in the history

  13. Cleaning up raft.dask.common.Comms

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d377347 View commit details
    Browse the repository at this point in the history

  14. Ignoring raft egg artifacts

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e1b4ea7 View commit details
    Browse the repository at this point in the history

  15. Cleaning up raft dask utils

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    736696b View commit details
    Browse the repository at this point in the history

  16. More cleanup, copyright headers, and docs

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    55d9dfd View commit details
    Browse the repository at this point in the history

  17. Removing the last of references to cuml

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    6eb0325 View commit details
    Browse the repository at this point in the history

  18. Fixing python style

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b65e20d View commit details
    Browse the repository at this point in the history

  19. Fixing c++ style

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    7a845cb View commit details
    Browse the repository at this point in the history

  20. Updating changelog

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c269300 View commit details
    Browse the repository at this point in the history

  21. Testing non-ucx cluster for pytests

    @cjnolet
    cjnolet committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d4aa5c5 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Implementing review feedback

    @cjnolet
    cjnolet committed May 18, 2020
    Configuration menu
    Copy the full SHA
    1ee1363 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. More review feedback

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    c165a36 View commit details
    Browse the repository at this point in the history

  2. Fixing style

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    12f3db7 View commit details
    Browse the repository at this point in the history

  3. FIX Use relative imports

    @dantegd
    dantegd committed May 19, 2020
    Configuration menu
    Copy the full SHA
    aae4625 View commit details
    Browse the repository at this point in the history

  4. Adding compile-time templates for comms_t to make interaction more st… 

    …raightforward
    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    bc39321 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1 from dantegd/fea-ext-comms-pr1 

    [WIP] Use relative imports
    @cjnolet
    cjnolet authored May 19, 2020
    Configuration menu
    Copy the full SHA
    e9c0995 View commit details
    Browse the repository at this point in the history

  6. Using std::this_thread::yield instead of pthread_yield()

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    3150fbd View commit details
    Browse the repository at this point in the history

  7. Adding python tests for collective functions

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5628ad2 View commit details
    Browse the repository at this point in the history

  8. Running cpp style

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    488d0d5 View commit details
    Browse the repository at this point in the history

  9. Updating tabbing for pytests

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    3d362d0 View commit details
    Browse the repository at this point in the history

  10. Following clang tidy standards

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    417a4bd View commit details
    Browse the repository at this point in the history

  11. Moving get_type out of comms_t

    @cjnolet
    cjnolet committed May 19, 2020
    Configuration menu
    Copy the full SHA
    cb92349 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. More review feedback

    @cjnolet
    cjnolet committed May 26, 2020
    Configuration menu
    Copy the full SHA
    6e9025d View commit details
    Browse the repository at this point in the history

  2. Running cpp style check

    @cjnolet
    cjnolet committed May 26, 2020
    Configuration menu
    Copy the full SHA
    28f8101 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Nccl red op

    @cjnolet
    cjnolet committed May 27, 2020
    Configuration menu
    Copy the full SHA
    1a18553 View commit details
    Browse the repository at this point in the history

  2. Raising an exception to get around gcc issue

    @cjnolet
    cjnolet committed May 27, 2020
    Configuration menu
    Copy the full SHA
    a22dd62 View commit details
    Browse the repository at this point in the history

  3. Using static for functions for now

    @cjnolet
    cjnolet committed May 27, 2020
    Configuration menu
    Copy the full SHA
    fbd12aa View commit details
    Browse the repository at this point in the history

  4. Fixing style

    @cjnolet
    cjnolet committed May 27, 2020
    Configuration menu
    Copy the full SHA
    cc71ccb View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Fixing more relative imports

    @cjnolet
    cjnolet committed May 28, 2020
    Configuration menu
    Copy the full SHA
    dc123b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. final updates based on feedback

    @cjnolet
    cjnolet committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    60597f3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-0.15' into fea-ext-comms

    @afender
    afender authored Jun 3, 2020
    Configuration menu
    Copy the full SHA
    5bbb8be View commit details
    Browse the repository at this point in the history