Update to thrust 1.17 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
bdice
reviewed
Aug 1, 2022
robertmaynard
force-pushed
the
update_to_thrust_1.16
branch
from
8cfd146
to
e13ce6e
Compare
robertmaynard
force-pushed
the
update_to_thrust_1.16
branch
from
e13ce6e
to
824d5af
Compare
bdice
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
LGTM. @robertmaynard:
- I'll make a libcudf PR as soon as possible so this can be merged at the same time.
- I think we need to set a custom Thrust/CUB namespace for all rapids-cmake packages. That should be a separate PR, in my opinion, but wanted to bring that to your attention and get your thoughts.
3 tasks
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 11, 2022
Updates the bundled version of Thrust to 1.17.0. I will run benchmarks and include results in a comment below. Depends on #11457. Supersedes #10489, #10577, #10586. Closes #10841. **This should be merged concurrently with rapidsai/rapids-cmake#231 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Robert Maynard (https://github.com/robertmaynard) URL: #11437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out the Thrust bump from #227 so that we can roll out changes slowly and have an easier time to track down issues.
Once this is in and RAPIDS is happy, we can go ahead and merge #199 which has breaking changes.