Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dask-expr to 1.1.14 for the 24.10 RAPIDS release #64

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Pin dask-expr to 1.1.14 for the 24.10 RAPIDS release #64

merged 1 commit into from
Sep 23, 2024

Conversation

rjzamora
Copy link
Member

Follow up to #60

Dask 2024.9.0 does not automatically pin the correct version of dask-expr, so we need to be very specific.

@rjzamora rjzamora added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 23, 2024
@rjzamora rjzamora self-assigned this Sep 23, 2024
@rjzamora rjzamora requested a review from a team as a code owner September 23, 2024 21:46
@galipremsagar
Copy link
Contributor

Thanks @rjzamora for the fix, tested locally that this fixes the issue that is blocking CI. @pentschev I'm going to merge this PR now to unblock cudf CI and all other down-stream CIs currently blocked. Please feel free to comment or request changes on this PR at your convenience. Here is the CI error for reference: https://github.com/rapidsai/cudf/actions/runs/11000866145/job/30548041899?pr=16780

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 64b438b into rapidsai:branch-24.10 Sep 23, 2024
7 checks passed
@rjzamora rjzamora deleted the pin-dask-expr-1.1.14 branch September 23, 2024 21:56
@galipremsagar galipremsagar mentioned this pull request Sep 24, 2024
Merged
3 tasks
@pentschev
Copy link
Member

Thanks @rjzamora for the fix, tested locally that this fixes the issue that is blocking CI. @pentschev I'm going to merge this PR now to unblock cudf CI and all other down-stream CIs currently blocked. Please feel free to comment or request changes on this PR at your convenience. Here is the CI error for reference: https://github.com/rapidsai/cudf/actions/runs/11000866145/job/30548041899?pr=16780

Sure thing @galipremsagar , to be fair I just want to leave more room for discussion before the pinnings, as different members may have different requirements. Bug fixes should go in as soon as there's reasonable confidence it's fixing something. 🙂

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Sep 24, 2024
@galipremsagar
Update oldest deps for pyarrow & numpy (#16883)
73fa557 
We recently pinned our `dask-expr` version to `1.1.14`: rapidsai/rapids-dask-dependency#64, that plus latest `dask` seems to be having a minimum requirement for `pyarrow` as `14.0.1`. This is causing failures in our CI matrix while running tests with the oldest dependencies. This PR bumps the minimum pyarrow version in our oldest deps.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees

@rjzamora rjzamora

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjzamora @galipremsagar @pentschev