always mark Python 3.11 jobs as successful #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jameslamb
changed the title
jameslamb
requested review from
vyasr,
bdice and
ajschmidt8
and removed request for
vyasr
jameslamb
added
improvement
3 tasks
bdice
reviewed
Feb 28, 2024
| if: "!cancelled()" | ||
| run: rapids-upload-artifacts-dir cuda${RAPIDS_CUDA_VERSION%%.*}_$(arch)_py${RAPIDS_PY_VERSION//.} | ||
|
|
||
| # TODO: remove before closing https://github.com/rapidsai/build-planning/issues/3 | ||
| - name: mark Python 3.11 jobs successful |
There was a problem hiding this comment.
I'm not 100% sure if this step is necessary, but it doesn't hurt. We have enough testing to know that this PR will help unblock CI.
ajschmidt8
approved these changes
Feb 28, 2024
bdice
approved these changes
Feb 28, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #176.
#176 added Python 3.11 build and test jobs. It tried to make those optional by using GitHub Actions'
jobs.<job_id>.continue_on_errormechanism (docs on that).Unfortunately, it seems that that mechanism doesn't play nicely with RAPIDS branch protections, which use one more job that runs at the end of the
prworkflow and declares all other sets of jobs in aneeds:block.cudfexample: https://github.com/rapidsai/cudf/blob/8526e6d5b21361465d1c72ecbea64d3d2d9bf849/.github/workflows/pr.yaml#L13-L34.As a result, the Python 3.11 jobs were actually blocking CI in repos where they were failing.
This proposes the following changes:
continue-on-errorHow I tested this
Opened rapidsai/cudf#15172 to test.
On the first run, I saw all Python 3.11 marked as successful, even though their logs clearly indicated that they failed.
(build link)
TODO: once that completes, I'll do one more build that breaks the tests and shows that the non-Python-3.11 jobs are marked as failed.Proposing that we merge this without waiting on that test, to unblock CI for
cudf(and maybe other projects).