Skip to content

Commit

Permalink
fix conda deps, try to fix readthedocs builds
Browse files Browse the repository at this point in the history
  • Loading branch information
jameslamb committed May 6, 2024
1 parent 0a397f0 commit c8d91ca
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ build:
os: "ubuntu-22.04"
tools:
python: "mambaforge-22.9"
jobs:
pre_install:
- bash ci/build_docs_pre_install.sh

python:
install:
Expand Down
23 changes: 23 additions & 0 deletions ci/build_docs_pre_install.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/bash
# Copyright (c) 2024 NVIDIA CORPORATION.
#
# [description]
#
# ucx-py's docs builds require installing the library.
#
# It does that by running 'pip install .' from the root of the repo. This script
# is used to modify readthedocs' local checkout of this project's source code prior
# to that 'pip install' being run.
#
# For more, see https://docs.readthedocs.io/en/stable/build-customization.html
#
# NOTE: This can go away if/when this project is cut over to rapids-build-backend.
# See https://github.com/rapidsai/build-planning/issues/31
#

set -euo pipefail

# just remove libucx dependency from pyproject.toml... it's not necessary for docs builds,
# and it's unsuffixed (e.g. no `-cu12`) in source control
cat ./pyproject.toml | grep -v '"libucx' > pyproject.bak
mv ./pyproject.bak ./pyproject.toml
3 changes: 2 additions & 1 deletion conda/recipes/ucx-py/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ requirements:
- python
- pip
- ucx
{% for r in data.get("build-system", {}).get("requires", []) %}
# 'libucx' wheel dependency is unnecessary... the 'ucx' conda-forge package is used here instead
{% for r in data.get("build-system", {}).get("requires", []) if not r.startswith("libucx") %}
- {{ r }}
{% endfor %}
run:
Expand Down

0 comments on commit c8d91ca

Please sign in to comment.