Slightly relax libxgboost pin
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
loosen_libxgboost_pin
branch
from
136ae21
to
6fcfe03
Compare
Pinning to exact package hash is too stringent as there are now CPU & CUDA builds of `libxgboost` that are used interchangeably by downstream XGBoost packages. So drop the package hash constraint, but match the rest of the version and build string as much as possible. This should fix some install issues we have seen due to the exact constraint that was here before.
jakirkham
force-pushed
the
loosen_libxgboost_pin
branch
from
6fcfe03
to
8bcb9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning to exact package hash is too stringent as there are now CPU & CUDA builds of
libxgboostthat are used interchangeably by downstream XGBoost packages. So drop the package hash constraint, but match the rest of the version and build string as much as possible. This should fix some install issues we have seen due to the exact constraint that was here before.