Factor out test GitHub Action

rasmuskriest · May 21, 2020 · 39af976 · 39af976
1 parent c1cffd4
commit 39af976
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 32 deletions.
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
@@ -0,0 +1,42 @@
+name: Code quality
+on:
+  pull_request:
+  push:
+    branches:
+    - master
+    tags:
+    - v*
+jobs:
+  formatting:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Set up Go
+      uses: actions/setup-go@v1
+      with:
+        go-version: ${{ matrix.go-version }}
+    - name: Cache Go modules
+      uses: actions/cache@v1
+      with:
+        path: ~/go/pkg/mod
+        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+        restore-keys: |
+          ${{ runner.os }}-go-
+    - name: Checkout
+      uses: actions/checkout@v2
+    - name: Generate
+      run: |
+        go generate
+        git diff --exit-code
+    - name: Check formatting
+      run: |
+        make format
+        git diff --exit-code
+  golangci-lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v1
+        with:
+          version: v1.27
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
diff --git a/.github/workflows/chezmoi.yml → .github/workflows/test.yml b/.github/workflows/chezmoi.yml → .github/workflows/test.yml
@@ -1,11 +1,11 @@
-name: chezmoi
+name: Test
 on:
   pull_request:
   push:
     branches:
     - master
     tags:
-    - 'v*'
+    - v*
 jobs:
   test:
     strategy:
@@ -31,27 +31,17 @@ jobs:
           ${{ runner.os }}-go-
     - name: Checkout
       uses: actions/checkout@v2
-    - name: Generate
-      if: matrix.os == 'ubuntu-latest'
-      run: |
-        go generate
-        git diff --exit-code
     - name: Build
       run: go build ./...
     - name: Run
       run: go run . --version
     - name: Test
       run: go test -race ./...
-    - name: Check formatting
-      if: matrix.os == 'ubuntu-latest'
-      run: |
-        make format
-        git diff --exit-code
     - name: Install snapcraft
       if: matrix.os == 'ubuntu-latest'
       run: |
         sudo apt-get -yq --no-install-suggests --no-install-recommends install snapcraft
-    - name: Release
+    - name: Build release
       if: matrix.os == 'ubuntu-latest'
       uses: goreleaser/goreleaser-action@v1
       with:
@@ -66,7 +56,6 @@ jobs:
         ./dist/chezmoi-nocgo_linux_386/chezmoi --version | tee /dev/stderr | grep -q "chezmoi version v"
         ./dist/chezmoi-nocgo-snap_linux_386/chezmoi --version | tee /dev/stderr | grep -q "chezmoi version v"
   release:
-    name: Release
     if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
     needs:
     - test