Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX_RESTARTS is off by one, always reboots an extra time #576

Closed
C0rn3j opened this issue May 9, 2024 · 1 comment
Closed

MAX_RESTARTS is off by one, always reboots an extra time #576

C0rn3j opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@C0rn3j
Copy link

C0rn3j commented May 9, 2024

Describe the bug

If set to -1 or 0 it does nothing, if set to 1 it reboots twice (= 3 boots), if set to 2 it reboots thrice... even in the UI it ends up saying restart 2/1 if it is set to 1

Steps to reproduce the behaviour

Set MAX_RESTARTS=1 and see it happen twice

Device (s)

Raspberry Pi 5

Bootloader configuration.

[all]
BOOT_UART=0
POWER_OFF_ON_HALT=1
BOOT_ORDER=0xf41
USB_MSD_STARTUP_DELAY=1000
USB_MSD_DISCOVER_TIMEOUT=10000
USB_MSD_LUN_TIMEOUT=100
HDMI_DELAY=0
NET_INSTALL_ENABLED=0
PSU_MAX_CURRENT=5000
MAX_RESTARTS=1
XHCI_DEBUG=0x0

System

No response

Bootloader logs

No response

USB boot

No response

NVMe boot

No response

Network (TFTP boot)

No response
@timg236 timg236 added the bug Something isn't working label May 13, 2024
timg236 added a commit to timg236/rpi-eeprom that referenced this issue May 13, 2024
@timg236
2024-05-13: 2712: Add support for NVMe boot with PCIe switches (latest)
2945c91 
* Add preliminary support for booting NVMe devices behind PCIe switches.
  See: raspberrypi/firmware#1833
* Fix MAX_RESTARTS parameter
  See: raspberrypi#576
* arm_dt: Support HAT EEPROM dtparams
* Fix reporting of the partition number via DT
  See: raspberrypi#575
* Resolve HID counting bug which caused Network Install to fail on some keyboards
  See: Fixes raspberrypi#574
* Pull PCIE DET_WAKE high by default on CM5
@timg236 timg236 mentioned this issue May 13, 2024
Merged
timg236 added a commit that referenced this issue May 13, 2024
@timg236
2024-05-13: 2712: Add support for NVMe boot with PCIe switches (latest)
2b2c810 
* Add preliminary support for booting NVMe devices behind PCIe switches.
  See: raspberrypi/firmware#1833
* Fix MAX_RESTARTS parameter
  See: #576
* arm_dt: Support HAT EEPROM dtparams
* Fix reporting of the partition number via DT
  See: #575
* Resolve HID counting bug which caused Network Install to fail on some keyboards
  See: Fixes #574
* Pull PCIE DET_WAKE high by default on CM5
timg236 added a commit to timg236/rpi-eeprom that referenced this issue May 17, 2024
@timg236
pieeprom-2024-05-17: 2711: Ignore bootloader updates for Pi5 on Pi4 -…
e0c116e 
… (latest)

  * Add timestamps to UART log messages.
  * Add support for [tryboot] conditional the bootloader EEPROM
    config file.
    See: raspberrypi#454
  * Fix MAX_RESTARTS parameter
    See: raspberrypi#576
  * Add recovery_reboot option to config.txt for rpiboot which causes
    the system to reboot after updating the bootloader.
  * Improve secure-boot OTP provisioning logging.
  * Fix setting to enable secure-boot mode on Pi4B
timg236 added a commit that referenced this issue May 17, 2024
@timg236
pieeprom-2024-05-17: 2711: Ignore bootloader updates for Pi5 on Pi4 -…
768f4fb 
… (latest)

  * Add timestamps to UART log messages.
  * Add support for [tryboot] conditional the bootloader EEPROM
    config file.
    See: #454
  * Fix MAX_RESTARTS parameter
    See: #576
  * Add recovery_reboot option to config.txt for rpiboot which causes
    the system to reboot after updating the bootloader.
  * Improve secure-boot OTP provisioning logging.
  * Fix setting to enable secure-boot mode on Pi4B
@C0rn3j
Copy link
Author

C0rn3j commented Jun 7, 2024

I presume this should be closed now that it's fixed.

@C0rn3j C0rn3j closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timg236 @C0rn3j