Add support for adding rows to a table (#53)

.github/workflows/ci.yml

@@ -109,7 +109,11 @@ jobs:
         run: |
           cd $HOME
           virtualenv $HOME/venv
-          source $HOME/venv/bin/activate && pip install --find-links=${{ github.workspace }}/wheelhouse arcae[test]
+          export WHEELHOUSE=${{ github.workspace }}/wheelhouse
+          export PYABI=${{ matrix.python[1] }}
+          export WHEEL=$(find $HWEELHOUSE -type f | grep $PYABI)
+          echo "Installing $WHEEL"
+          source $HOME/venv/bin/activate && pip install $WHEEL[test]
           source $HOME/venv/bin/activate && py.test -s -vvv --pyargs arcae
 
   upload-to-test-pypi:

HISTORY.rst

@@ -4,6 +4,7 @@ History
 
 X.Y.Z (YYYY-MM-DD)
 ------------------
+* Add support for adding rows to a table (:pr:`53`)
 * Create and use JSON Table Descriptors and Data Managers (:pr:`51`)
 * Use ccache, if available (:pr:`50`)
 * Use vcpkg's internal github actions binary caching (:pr:`49`)

arcae/arrow_tables.pxd

@@ -39,6 +39,8 @@ cdef extern from "../cpp/safe_table_proxy.h" namespace "arcae" nogil:
         CResult[unsigned int] ncolumns " SafeTableProxy::ncolumns"()
         CResult[vector[string]] columns " SafeTableProxy::columns"()
         CResult[vector[shared_ptr[CCasaTable]]] partition " SafeTableProxy::partition"(const vector[string] & partition_columns, const vector[string] & sort_columns)
+        CResult[bool] addrows " SafeTableProxy::addrows"(unsigned int nrows)
+
 
 cdef extern from "../cpp/table_factory.h" namespace "arcae" nogil:
     cdef CResult[shared_ptr[CCasaTable]] copen_table" arcae::open_table"(

arcae/arrow_tables.pyx

@@ -180,6 +180,8 @@ cdef class Table:
 
         return result
 
+    def addrows(self, nrows: int):
+        return  GetResultValue(self.c_table.get().addrows(nrows))
 
 class Configuration(MutableMapping):
     def __getitem__(self, key: str):

arcae/tests/test_descriptors.py → arcae/tests/test_descriptor.py

@@ -1,3 +1,5 @@
+from numpy.testing import assert_array_equal
+
 from arcae.lib.arrow_tables import Table
 from arcae.lib.arrow_tables import ms_descriptor
 
@@ -9,6 +11,17 @@ def test_descriptor_basic():
     assert isinstance(ms_descriptor("SPECTRAL_WINDOW"), dict)
 
 
+def test_ms_addrows(tmp_path_factory):
+    ms = tmp_path_factory.mktemp("test") / "test.ms"
+    with Table.ms_from_descriptor(str(ms)) as T:
+        T.addrows(10)
+        assert T.nrow() == 10
+        AT = T.to_arrow()
+        assert len(AT) == 10
+        assert_array_equal(AT.column("TIME"), 0)
+        assert_array_equal(AT.column("ANTENNA1"), 0)
+        assert_array_equal(AT.column("ANTENNA2"), 0)
+
 def test_ms_and_weather_subtable(tmp_path_factory):
     ms = tmp_path_factory.mktemp("test") / "test.ms"
     with Table.ms_from_descriptor(str(ms)) as T:

cpp/safe_table_proxy.cpp

@@ -185,6 +185,17 @@ SafeTableProxy::partition(
 }
 
 
+Result<bool>
+SafeTableProxy::addrows(casacore::uInt nrows) {
+    ARROW_RETURN_NOT_OK(FailIfClosed());
+
+    return run_isolated([this, nrows]() -> Result<bool> {
+        this->table_proxy->addRow(nrows);
+        return true;
+    });
+}
+
+
 Result<bool>
 SafeTableProxy::close() {
     if(!is_closed) {

cpp/safe_table_proxy.h

@@ -83,6 +83,8 @@ class SafeTableProxy {
         const std::vector<std::string> & partition_columns={},
         const std::vector<std::string> & sort_columns={}) const;
 
+    arrow::Result<bool> addrows(casacore::uInt nrows);
+
     arrow::Result<bool> close();
 };