fix an issue where websocket crashes on internal control closeframe #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes an issue where websocket crashes on internal control closeframe.
The assertion being made in
src/mist/internal/websocket.gleam:232
crashes a webserver using mist websockets when the call returns an error.This fix appears to conform to the patterns in other case clauses, where there is no assertion made to the result from
connection.transport.send
. Given a better understanding of the purpose of this function however, there may be a better way to approach this.Closes #24