Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added context to the json formatter #350

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Added context to the json formatter #350

merged 1 commit into from
Aug 31, 2024

Conversation

raghumdani
Copy link
Collaborator

This PR adds additional context to the json formatter which allows us to log environment variables which can be used to filter right logs.

@raghumdani raghumdani marked this pull request as ready for review August 30, 2024 23:18
@yankevn
Copy link
Collaborator

yankevn commented Aug 31, 2024 •
edited
Loading

Do we actually set the context_kwargs anywhere in this PR?

@raghumdani
Copy link
Collaborator Author

Do we actually set the context_kwargs anywhere in this PR?

It will set in the driver.

@raghumdani raghumdani merged commit a5c0b8d into main Aug 31, 2024
3 checks passed
@raghumdani raghumdani deleted the logger-context branch August 31, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankevn yankevn yankevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raghumdani @yankevn