Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/ray/autoscaler/gcp/*.yaml: change scheduling from dict to list #46500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guoqiao
Copy link

@guoqiao guoqiao commented Jul 9, 2024

Why are these changes needed?

Related issue number

Closes #46248

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [] Unit tests
    • [] Release tests
    • This PR is not tested :(

Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, what's the behavior of the existing yaml if scheduling is list instead of dict?

@guoqiao guoqiao force-pushed the issue-46248-fix-gcp-config-scheduling branch from 8e86643 to ec4447f Compare July 10, 2024 08:20
@guoqiao
Copy link
Author

guoqiao commented Jul 10, 2024

Question, what's the behavior of the existing yaml if scheduling is list instead of dict?

@jjyao

Had a try with preemptible: true for ray 2.10.0 (the version we are using).

the result is same and correct for both list and object: vm showing Preemptiblity On in GCP.

Looks like there is a coincidence or workaround to make it work correctly, and that's why the issue is not discovered for so long.

I didn't get the time to try other fields and multi fields cases though.

@anyscalesam anyscalesam requested a review from jjyao July 22, 2024 23:10
@anyscalesam anyscalesam added @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoscaler][gcp] wrong values for scheduling in example gcp cluster yaml files
3 participants