Add diagnostic to disallow a parameter-direction on a template parame…

…ter, closes hsutter#425
raymyers · Aug 13, 2023 · d2a6cd7 · d2a6cd7
1 parent d88f72a
commit d2a6cd7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/regression-tests/test-results/version b/regression-tests/test-results/version
@@ -1,5 +1,5 @@
 
-cppfront compiler v0.2.1   Build 8812:1229
+cppfront compiler v0.2.1   Build 8812:1231
 Copyright(c) Herb Sutter   All rights reserved
 
 SPDX-License-Identifier: CC-BY-NC-ND-4.0

diff --git a/source/build.info b/source/build.info
@@ -1 +1 @@
-"8812:1229"
+"8812:1231"
diff --git a/source/parse.h b/source/parse.h
@@ -4731,7 +4731,7 @@ class parser
         }
     }
 
-    //G  expression:                // eliminated 'condition:' - just use 'expression:'
+    //G expression:               // eliminated 'condition:' - just use 'expression:'
     //G     assignment-expression
     //GTODO    try expression
     //G
@@ -4972,6 +4972,7 @@ class parser
 
     //G unqualified-id:
     //G     identifier
+    //G     keyword
     //G     template-id
     //GTODO     operator-function-id
     //G
@@ -5168,7 +5169,7 @@ class parser
     }
 
 
-    //G id-expression
+    //G id-expression:
     //G     qualified-id
     //G     unqualified-id
     //G
@@ -6013,6 +6014,11 @@ class parser
             dir != passing_style::invalid
             )
         {
+            if (is_template) {
+                error("a template parameter cannot have a passing style (it is always implicitly 'in')");
+                return {};
+            }
+
             if (!modifier.empty()) {
                 modifier += " ";
                 modifier_plural = "s";