Fix bug in StringQuery.string_match

rcrowell · Jan 26, 2022 · 2cab2d6 · 2cab2d6
1 parent 6457532
commit 2cab2d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py
@@ -191,7 +191,7 @@ def col_clause(self):
 
     @classmethod
     def string_match(cls, pattern, value):
-        return pattern == value
+        return pattern.lower() == value.lower()
 
 
 class SubstringQuery(StringFieldQuery):

diff --git a/test/test_query.py b/test/test_query.py
@@ -395,12 +395,12 @@ def test_substring_match_non_string_value(self):
     def test_exact_match_nocase_positive(self):
         q = dbcore.query.StringQuery('genre', 'the genre')
         self.assertTrue(q.match(self.item))
+        q = dbcore.query.StringQuery('genre', 'THE GENRE')
+        self.assertTrue(q.match(self.item))
 
     def test_exact_match_nocase_negative(self):
         q = dbcore.query.StringQuery('genre', 'genre')
         self.assertFalse(q.match(self.item))
-        q = dbcore.query.StringQuery('genre', 'THE GENRE')
-        self.assertFalse(q.match(self.item))
 
     def test_year_match_positive(self):
         q = dbcore.query.NumericQuery('year', '1')