Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] [Warnings] Treating warnings as errors in GitHub Actions, fixing many warnings #1393

Merged
merged 53 commits into from
Aug 16, 2023
Merged

[Actions] [Warnings] Treating warnings as errors in GitHub Actions, fixing many warnings #1393

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
2b4078c
Treat warnings as errors for the Linux build with cmake
VeithMetro Aug 1, 2023
bd63cfc
Triggering the action for my branch to check if it works
VeithMetro Aug 1, 2023
eb81173
Treat warnings as errors for C compilation
VeithMetro Aug 1, 2023
d319942
Enabling all warnings for Windows
VeithMetro Aug 1, 2023
4f72a9f
Enabling all possible warnings for the Linux build
VeithMetro Aug 1, 2023
36d49d4
Changing the build command for Windows, adding treating warnings are …
VeithMetro Aug 1, 2023
581f06b
Changing the warning level for Windows to level 4
VeithMetro Aug 1, 2023
077035e
Looks like we cannot change the warning level with devenv for Windows
VeithMetro Aug 1, 2023
ba98cde
Trying a different placement of the warning switch for devenv
VeithMetro Aug 1, 2023
cad300e
Warning settings cannot be changed using devenv, have to do that in p…
VeithMetro Aug 1, 2023
d5c6fd5
Dropping the ISO C++11 related warnings for now
VeithMetro Aug 1, 2023
23e335f
Not failing on warnings for now to get a full list of warnings
VeithMetro Aug 1, 2023
57efdbb
Removing pedantic warnings for now
VeithMetro Aug 1, 2023
f88eb96
Merge branch 'rdkcentral:master' into development/actions-warnings
VeithMetro Aug 4, 2023
3ba00e3
Range loop construct - making sure the reference is used instead of a…
VeithMetro Aug 4, 2023
6c91450
Initialization order fix - ProxyPoolTypes order in TraceFactoryType
VeithMetro Aug 4, 2023
d5e7e10
Changing the branch to checkout to see if warnings are fixed
VeithMetro Aug 4, 2023
2c2420d
Checkouting my fork instead of the rdkcentral repo for now
VeithMetro Aug 4, 2023
a2bea26
Properly fixing a warning with one of the loops
VeithMetro Aug 4, 2023
852a43e
Merge branch 'development/actions-warnings' of github.com:VeithMetro/…
VeithMetro Aug 4, 2023
8a701db
Fixing a warning with yet another loop
VeithMetro Aug 4, 2023
c81cb38
Adding pedantic warnings to actions as the serious ones are fixed
VeithMetro Aug 4, 2023
439f376
Removing extra semicolons in PUSH_WARNING macro uses
VeithMetro Aug 8, 2023
3aa8953
Merge branch 'development/actions-warnings' of github.com:VeithMetro/…
VeithMetro Aug 8, 2023
8df5f04
Removing extra semicolons in POP_WARNING macro uses
VeithMetro Aug 8, 2023
c895d7e
Adding a missing message to the static_assert in Frame.h
VeithMetro Aug 8, 2023
ca483f6
ReceiveFrom function in SocketPort is now inside extern C
VeithMetro Aug 8, 2023
ab9b2b7
Removing an unused variable in SecureSocketPort
VeithMetro Aug 8, 2023
8aac837
Changing binary values to hex to supress warnings
VeithMetro Aug 8, 2023
6c8110e
Casting to a void pointer to suppress a warning in TRACE_L1 macro use
VeithMetro Aug 8, 2023
0a9bce2
Dropping the extern C to avoid namespace issues, and declaring struct…
VeithMetro Aug 8, 2023
a9e1570
Changing VLAs to ALLOCA macro, fixing the wrong array size, removing …
VeithMetro Aug 9, 2023
661663a
Dereferencing an array pointer in sizeof()
VeithMetro Aug 9, 2023
05d3c56
Adding pragma to ignore pedantic warnings for macro definitions
VeithMetro Aug 9, 2023
10a2614
Adding a macro disabling pedantic warning to Portability and using it…
VeithMetro Aug 10, 2023
0d80928
Modifying PUSH_WARNING macro to be warning free with pedantic flag en…
VeithMetro Aug 10, 2023
41b0ff5
Trying to suppress variadic macros warning instead of pedantic one si…
VeithMetro Aug 10, 2023
02b156e
Trying another way of disabling variadic macros warnings
VeithMetro Aug 10, 2023
aea02b0
Adding pragmas to macro use instead of definition to check if it works
VeithMetro Aug 10, 2023
dcb1850
Moving the pragmas outside the scope
VeithMetro Aug 10, 2023
01fa70d
Using GCC system_header pragma to try to disable the warning
VeithMetro Aug 10, 2023
804809a
Trying to use only the gcc system header method since seems like it i…
VeithMetro Aug 10, 2023
28ec514
Including PUSH_WARNING_ARG macro in the system header
VeithMetro Aug 10, 2023
0b96111
Trying to include more macros in system header to make the warning go…
VeithMetro Aug 10, 2023
8de9317
Making TRACE_Lx macros inside gcc system header to suppress warnings
VeithMetro Aug 10, 2023
32b97f3
Moving the system header declaration before TRACE_FORMATTING_IMPL mac…
VeithMetro Aug 10, 2023
33b157c
Minor code formatting changes
VeithMetro Aug 10, 2023
37e81ad
Merge branch 'rdkcentral:master' into development/actions-warnings
VeithMetro Aug 10, 2023
232e607
Preparing the build on Windows action for merging
VeithMetro Aug 10, 2023
cf540f7
Enabling treating warnings as errors for the final test before merging
VeithMetro Aug 10, 2023
20ea6c0
Preparing the Linux build to be merged
VeithMetro Aug 10, 2023
0da2b41
Fixing the size of an array passed to memset
VeithMetro Aug 10, 2023
3825bf0
Merge branch 'development/actions-warnings' of github.com:VeithMetro/…
VeithMetro Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Initialization order fix - ProxyPoolTypes order in TraceFactoryType
  • Loading branch information
@VeithMetro
VeithMetro committed Aug 4, 2023
commit 6c914502f168a6601f9703518803206c4ce2bdcc
2 changes: 1 addition & 1 deletion Source/messaging/TraceFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ namespace Messaging {
}

private:
Core::ProxyPoolType<METADATA> _metadataPool;
Core::ProxyPoolType<EVENT> _eventPool;
Core::ProxyPoolType<METADATA> _metadataPool;
};

} // namespace Messaging
Expand Down