Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Changing Windows build to catch the potential fail in a single project #1425

Merged
merged 8 commits into from
Oct 13, 2023
Merged

[Actions] Changing Windows build to catch the potential fail in a single project #1425

merged 8 commits into from
Oct 13, 2023

Conversation

VeithMetro
Copy link
Contributor

No description provided.

@VeithMetro
Copy link
Contributor Author

VeithMetro commented Oct 10, 2023 •
edited
Loading

The last "fix" (using _write() instead of write() as it is deprecated on Windows and was causing a build error) produced a build error not in Thunder, but in the MessageControl plugin where Format() is used. In short, write() won't compile under Windows, and apparently _write() won't compile under Linux either, so I separated them with ifdef to compile on both Windows and Linux

@VeithMetro VeithMetro mentioned this pull request Oct 10, 2023
Merged
@pwielders pwielders merged commit edbc9ac into rdkcentral:master Oct 13, 2023
19 checks passed
@VeithMetro VeithMetro deleted the development/actions-windows-fix branch November 6, 2023 09:41
@VeithMetro VeithMetro restored the development/actions-windows-fix branch November 6, 2023 09:41
@VeithMetro VeithMetro deleted the development/actions-windows-fix branch November 6, 2023 09:41
bramoosterhuis pushed a commit to bramoosterhuis/Thunder that referenced this pull request Apr 26, 2024
@VeithMetro @MFransen69
@pwielders @bramoosterhuis
[Actions] Changing Windows build to catch the potential fail in a sin…
02b223d 
…gle project (rdkcentral#1425)

* Create Documentation Required Checks workflow

* Changing Windows build action to logical sum to catch potential fails

* Running action on this branch to test

* Removing the local test to prepare for a pull request

* Separating the use of write and _write to Linux and Windows, since neither of them compiles on both

---------

Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com>
Co-authored-by: Pierre Wielders <pierre@wielders.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwielders pwielders pwielders approved these changes

@sebaszm sebaszm Awaiting requested review from sebaszm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VeithMetro @pwielders @MFransen69