[Actions] GitHub Actions will now also built upwards dependencies but they won't block merging #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it seems I have to use the one from my branch in this initial pull requests..
sebaszm
previously approved these changes
Jan 11, 2024
VeithMetro
changed the title
sebaszm
approved these changes
Jan 11, 2024
This was referenced Jan 12, 2024
bramoosterhuis
pushed a commit
to bramoosterhuis/Thunder
that referenced
this pull request
Apr 26, 2024
… they won't block merging (rdkcentral#1496) * Create Linux build template * Use the Linux build template * Building additional repos in separate jobs as not required checks * Checking if non required actions won't block the merge * Checking if commenting works as intended * Final prep for a merge * Apparently the new workflow cannot be initialized before merging So it seems I have to use the one from my branch in this initial pull requests.. * Trying to enable other builds --------- Co-authored-by: Pierre Wielders <pierre@wielders.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pull request - the new workflows have to be called from my branches for now (there is a dependency between the workflows), since we need to first merge new templates in each repo. Then, I'll make one more set of pull requests to redirect this new feature to master branches of our repos.
Required checks got updated to the new ones by Stephen.