[Actions] Adding process containers with runC backend to be built in the Linux workflow #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch did not match the buffer size on top of that
MFransen69
approved these changes
Jun 20, 2024
msieben
pushed a commit
that referenced
this pull request
Jun 21, 2024
…the Linux workflow (#1655) * Fixing warnings in RunC process containers * Adding containers to Actions * Removing PROCESSCONTAINERS_CLIB option as it was the same as RunC * Temporarily using a template from development to test the changes * Using sizeof to get the size of a buffer instead of a fixed value which did not match the buffer size on top of that * Changing back to use template from master
MFransen69
added a commit
that referenced
this pull request
Jun 26, 2024
* [Tests/init/core] : Separate 'tests' from 'core' namespaces. Initial changes by mostly search and replace. * [Tests/unit/core] : partially revert '8a3fe02b8a9f3ff7c3672942d2ee906115420956' to include 'test_messageException' * [Tests/unit / Tests/unit/core] : Do not depend on 'IPTestAdministrator' if it not used * [Tests/unit/core] : Make explicit global namespace lookup * [DOC] Singletons section (#1540) * singleton section added * singletons documentation section added * singletons.md added to mkdocs.yml * warning fixed * formating fix * singletons description addded * [doc] description of singletons added * Update singletons.md --------- Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com> * [Actions] Adding process containers with runC backend to be built in the Linux workflow (#1655) * Fixing warnings in RunC process containers * Adding containers to Actions * Removing PROCESSCONTAINERS_CLIB option as it was the same as RunC * Temporarily using a template from development to test the changes * Using sizeof to get the size of a buffer instead of a fixed value which did not match the buffer size on top of that * Changing back to use template from master * [Tests/unit/core] : more use of full nested namespaces * [Tests/unit/core] : remove 'using' in 'test_hash' * Revert "[Tests/unit / Tests/unit/core] : Do not depend on 'IPTestAdministrator' if it not used" This reverts commit 7ac0335. --------- Co-authored-by: Piotr Czekaj <pczekajj@gmail.com> Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com> Co-authored-by: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com>
MFransen69
added a commit
that referenced
this pull request
Jul 16, 2024
* [Tests/init/core] : Separate 'tests' from 'core' namespaces. Initial changes by mostly search and replace. * [Tests/unit/core] : partially revert '8a3fe02b8a9f3ff7c3672942d2ee906115420956' to include 'test_messageException' * [Tests/unit / Tests/unit/core] : Do not depend on 'IPTestAdministrator' if it not used * [Tests/unit/core] : Make explicit global namespace lookup * [DOC] Singletons section (#1540) * singleton section added * singletons documentation section added * singletons.md added to mkdocs.yml * warning fixed * formating fix * singletons description addded * [doc] description of singletons added * Update singletons.md --------- Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com> * [Actions] Adding process containers with runC backend to be built in the Linux workflow (#1655) * Fixing warnings in RunC process containers * Adding containers to Actions * Removing PROCESSCONTAINERS_CLIB option as it was the same as RunC * Temporarily using a template from development to test the changes * Using sizeof to get the size of a buffer instead of a fixed value which did not match the buffer size on top of that * Changing back to use template from master * [Tests/unit/core] : more use of full nested namespaces * [Tests/unit/core] : remove 'using' in 'test_hash' * Revert "[Tests/unit / Tests/unit/core] : Do not depend on 'IPTestAdministrator' if it not used" This reverts commit 7ac0335. * [Tests/unit/tests] : align namespace usage for 'test_iptestadministrator' --------- Co-authored-by: Piotr Czekaj <pczekajj@gmail.com> Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com> Co-authored-by: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was described in this Jira ticket: https://jira.rdkcentral.com/jira/browse/METROL-994
The other backends need some dependencies, so it would be more tricky to add them as well, but like we discussed - one should be enough just to make sure it compiles after any changes.
Also, the target source of
PROCESSCONTAINERS_CLIBoption wasRunCImplementation.cpp, just like in case of thePROCESSCONTAINERS_RUNCoption, so it seems we can remove one of them.