Upstream RDK adapter

[kkanag314]

No description provided.

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: 85c3876

Report detail: gist

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: c871266

Report detail: gist

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: c871266

Report detail: gist

[mhughesacn]

Hi Krishna: Who created the new file open_cdm_adapter.cpp (i.e. RDK/Metrological/Comcast etc., not the contracting company) - please confirm whose copyright applies.
Thank you.

[DouglasAdler]

@mhughesacn The rdk adapter already has a copyright header.

• Copyright 2020 RDK Management

This file was created by Comcast but is already used by the open source RDK licensees.

[mhughesacn]

Hi Doug: In this component, the default header is Metrological Apache, but Comcast Apache would be OK too as it is your file. However, there are some RDK Apache headers already, so I don't think it fair to block.

[rdkcmf-jenkins]

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

• Upvote reason: Prefer Metro or Comcast header, but RDK already in use.

• Commit: c871266

[DouglasAdler]

Thanks, I had this header in there on the guidance of RDK-M.  I'm happy to change it to what the current component uses as it's now part of this repo. On Tuesday, March 26, 2024 at 09:24:44 AM CDT, mhughesacn ***@***.***> wrote: Hi Doug: In this component, the default header is Metrological Apache, but Comcast Apache would be OK too as it is your file. However, there are some RDK Apache headers already, so I don't think it fair to block. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

[mhughesacn]

Hi Doug:
The guidance on this has shifted a bit. By default, headers were Metrological as it was originally a Metrological component. However, it is reasonable to use your own header if it's your file i.e. Comcast. If the file is a copy of something in RDK land, then RDK header. If you do use Comcast, then for good housekeeping, please add a two liner credit to NOTICE if not already there:
Copyright 2020 Comcast Cable Communications Management, LLC
Licensed under the Apache License, Version 2.0

Honest answer is that you not have to look very far to find places where this isn't observed :-)

[sramani-metro]

Would like to get some things clarified as mentioned in the comments.

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: 0ea0756

Report detail: gist

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: cf6f7bf

Report detail: gist

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: 1f894e4

Report detail: gist

[rdkcmf-jenkins]

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

• Upvote reason: Not blocking - RDK copyright already in use

• Commit: 1f894e4

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/ThunderClientLibraries/250/rdkcentral/ThunderClientLibraries

• Commit: 2268047

Report detail: gist

[rdkcmf-jenkins]

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

• Upvote reason: Allow RDK hdr

• Commit: 2268047

[CLAassistant]

All committers have signed the CLA.

[sramani-metro]

Looks good to me.

[kkanag314]

@pwielders Could you please review the changes

[sramani-metro]

Looks good.