Merge branch 'master' into homepage

.all-contributorsrc

@@ -0,0 +1,38 @@
+{
+  "projectName": "cra-template-react-boilerplate",
+  "projectOwner": "cra-template-react-boilerplate",
+  "repoType": "github",
+  "repoHost": "https://github.com",
+  "files": [
+    "README.md"
+  ],
+  "imageSize": 80,
+  "commit": true,
+  "contributors": [
+    {
+      "login": "Can-Sahin",
+      "name": "Can Sahin",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/33245689",
+      "profile": "https://github.com/Can-Sahin",
+      "contributions": [
+        "code",
+        "doc",
+        "ideas",
+        "review",
+        "test"
+      ]
+    },
+    {
+      "login": "receptiryaki",
+      "name": "Recep Tiryaki",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/3495307",
+      "profile": "https://github.com/receptiryaki",
+      "contributions": [
+        "code",
+        "ideas"
+      ]
+    }
+  ],
+  "contributorsPerLine": 8,
+  "commitConvention": "none"
+}

.github/workflows/build.yaml

@@ -0,0 +1,22 @@
+name: Build
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 10.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 10.x
+      - run: npm i # There is a bug with npm ci -> https://github.com/npm/cli/issues/558
+      - run: npm run generate-cra:test
+        env:
+          CI: true
+      # - run: npm run test --if-present
+      #   env:
+      #     CI: true

.github/workflows/lint.yaml

@@ -0,0 +1,13 @@
+name: Lint
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - run: npm i # There is a bug with npm ci -> https://github.com/npm/cli/issues/558
+      - run: npm run lint

README.md

@@ -1,6 +1,114 @@
-# cra-template-react-boilerplate
+# UNDER DEVELOPMENT! DO NOT USE
 
+**Details will follow...**
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
+<br />
 
-**This is the early test version of the [react-boilerplate](https://github.com/react-boilerplate/react-boilerplate)'s `official` custom template for the [create-react-app](https://github.com/facebook/create-react-app)**
+<img src="https://raw.githubusercontent.com/react-boilerplate/react-boilerplate-brand/master/assets/banner-metal-optimized.jpg" alt="react boilerplate banner" align="center" />
+<br />
+<div align="center"><strong>Create React App template of React Boilerplate </strong></div>
+<br />
+<div align="center">Crafted for <strong>highly scalable</strong>, <strong>easily maintainable</strong> and <strong>highly performant</strong> React.js applications with a focus on <strong>best DX</strong> and <strong>best practices</strong>.</div>
 
-More details & documentation will follow...
+<br />
+
+<div align="center">
+  <a href="https://david-dm.org/can-sahin/cra-template-react-boilerplate">
+    <img src="https://david-dm.org/can-sahin/cra-template-react-boilerplate.svg" alt="Dependency Status" />
+  </a>
+  <a href="https://david-dm.org/can-sahin/cra-template-react-boilerplate#info=devDependencies">
+    <img src="https://david-dm.org/can-sahin/cra-template-react-boilerplate/dev-status.svg" alt="devDependency Status" />
+  </a>
+  <a href="https://github.com/Can-Sahin/cra-template-react-boilerplate/actions?query=workflow%3Abuild">
+    <img src="https://github.com/Can-Sahin/cra-template-react-boilerplate/workflows/build/badge.svg" alt="Build Status" />
+  </a>
+</a>
+
+</div>
+<div align="center">
+  <a href="https://opencollective.com/react-boilerplate">
+    <img src="https://opencollective.com/react-boilerplate/backers/badge.svg" alt="Backers" />
+  </a>
+  <a href="https://opencollective.com/react-boilerplate/">
+    <img src="https://opencollective.com/react-boilerplate/sponsors/badge.svg" alt="Sponsors" />
+  </a>
+  <a href="">
+    <img src="https://img.shields.io/github/license/can-sahin/cra-template-react-boilerplate" alt="License" />
+  </a>
+</div>
+
+<br />
+
+---
+
+The official [Create React App](https://github.com/facebook/create-react-app) template of [React Boilerplate](https://github.com/react-boilerplate/react-boilerplate)
+![](https://img.shields.io/github/stars/react-boilerplate/react-boilerplate?style=flat)
+![](https://img.shields.io/github/contributors/react-boilerplate/react-boilerplate)
+
+Start your `create-react-app` projects in seconds with the best, industry-standard tools and practices made ready for you
+
+```sh
+npx create-react-app --template cra-template-react-boilerplate my-app
+cd my-app
+npm start
+```
+
+---
+
+## Features
+
+## Contributors
+
+<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
+<!-- prettier-ignore-start -->
+<!-- markdownlint-disable -->
+<table>
+  <tr>
+    <td align="center"><a href="https://github.com/Can-Sahin"><img src="https://avatars2.githubusercontent.com/u/33245689" width="80px;" alt=""/><br /><sub><b>Can Sahin</b></sub></a><br /><a href="https://github.com/cra-template-react-boilerplate/cra-template-react-boilerplate/commits?author=Can-Sahin" title="Code">💻</a> <a href="https://github.com/cra-template-react-boilerplate/cra-template-react-boilerplate/commits?author=Can-Sahin" title="Documentation">📖</a> <a href="#ideas-Can-Sahin" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/cra-template-react-boilerplate/cra-template-react-boilerplate/pulls?q=is%3Apr+reviewed-by%3ACan-Sahin" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/cra-template-react-boilerplate/cra-template-react-boilerplate/commits?author=Can-Sahin" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://github.com/receptiryaki"><img src="https://avatars0.githubusercontent.com/u/3495307" width="80px;" alt=""/><br /><sub><b>Recep Tiryaki</b></sub></a><br /><a href="https://github.com/cra-template-react-boilerplate/cra-template-react-boilerplate/commits?author=receptiryaki" title="Code">💻</a> <a href="#ideas-receptiryaki" title="Ideas, Planning, & Feedback">🤔</a></td>
+  </tr>
+</table>
+
+<!-- markdownlint-enable -->
+<!-- prettier-ignore-end -->
+
+<!-- ALL-CONTRIBUTORS-LIST:END -->
+
+This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
+
+## License
+
+This project is licensed under the MIT license, Copyright (c) 2019 Maximilian
+Stoiber. For more information see `LICENSE.md`.

internals/scripts/generate-cra.ts

@@ -4,11 +4,7 @@ import {
   generateTemplateFolder,
   removeTemplateFolder,
 } from './generate-template-folder';
-import {
-  shellEnableAbortOnFail,
-  shellDisableAbortOnFail,
-  parseArgv,
-} from './utils';
+import { shellEnableAbortOnFail, shellDisableAbortOnFail } from './utils';
 
 interface Options {
   forTesting?: boolean;
@@ -23,7 +19,7 @@ export function generateCRA(opts: Options = {}) {
 
   shell.rm('-rf', `${craAppName}`);
 
-  generateTemplateFolder();
+  generateTemplateFolder(opts);
 
   shell.echo('Generating CRA...');
 
@@ -50,5 +46,5 @@ export function generateCRA(opts: Options = {}) {
 process.chdir(path.join(__dirname, '../..'));
 
 generateCRA({
-  forTesting: parseArgv(process.argv, 'forTesting', true) as boolean,
+  forTesting: process.env.NODE_ENV === 'test' || process.env.CI === 'true',
 });

package.json

@@ -35,24 +35,24 @@
     "build": "react-scripts build",
     "test": "react-scripts test",
     "eject": "react-scripts eject",
-    "typecheck": "tsc --noEmit && npm run lint",
+    "checkTs": "tsc --noEmit",
     "lint": "eslint --ext js,ts,tsx src",
-    "lint:fix": "eslint --ext js,ts,tsx src --fix",
+    "lint:fix": "eslint --ext js,ts,tsx --fix src",
     "prettify": "prettier --write",
     "generate-cra": "ts-node --project=./internals/ts-node.tsconfig.json ./internals/scripts/generate-cra.ts",
-    "generate-cra:test": "npm run generate-cra -- --forTesting"
+    "generate-cra:test": "cross-env NODE_ENV=test && npm run generate-cra"
   },
   "lint-staged": {
     "*.{ts,tsx,js,jsx}": [
-      "npm run lint:fix"
+      "eslint --ext js,ts,tsx --fix"
     ],
     "*.{md,json}": [
       "prettier --write"
     ]
   },
   "husky": {
     "hooks": {
-      "pre-commit": "lint-staged && npm run typecheck"
+      "pre-commit": "lint-staged && npm run checkTs"
     }
   },
   "dependencies": {