Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ctrl n/p on mac #650

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Conversation

wzhudev
Copy link
Contributor

@wzhudev wzhudev commented Aug 11, 2021

Use ctrl + n / p to select list items. Closing ant-design/ant-design#31641.

@vercel
Copy link

vercel bot commented Aug 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/F4iG4MHajbgLBhREa1RAqKMAn17B
✅ Preview: https://select-git-fork-wendellhu95-feature-ctrlnp-react-component.vercel.app

@wzhudev
Copy link
Contributor Author

wzhudev commented Aug 11, 2021

@afc163 @zombieJ Could you please take a look at this?

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #650 (0bdc462) into master (6b3dda7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          20       20           
  Lines        1004     1011    +7     
  Branches      340      334    -6     
=======================================
+ Hits          995     1002    +7     
  Misses          8        8           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.24% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3dda7...0bdc462. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 12, 2021

覆盖率掉了

@wzhudev
Copy link
Contributor Author

wzhudev commented Aug 12, 2021

覆盖率掉了

那我在测试环境里 mock 一下 platformUtil 这个文件吧。

@wzhudev
Copy link
Contributor Author

wzhudev commented Aug 12, 2021

覆盖率掉了

Codecov 似乎得手动重跑一下

src/utils/platformUtil.ts Outdated Show resolved Hide resolved
@afc163 afc163 merged commit f58ab23 into react-component:master Aug 13, 2021
@wzhudev wzhudev deleted the feature/ctrlnp branch August 13, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants