BREAKING CHANGE: drop core-js from dependencies which the app should be responsible for

[gfx]

Any polyfills, not ponyfills which does not affect the global env, should be injected by the application, not by the library.

If you think this PR is okay, please add "sideEffects": false to package.json.

---

This is a breaking change (i.e. semver-major) because it may require the application code changes.

[okonet]

@rxmarbles what do you think? Also I'd like to move this package to react-dropzone org. Thoughts?

[rxmarbles]

@okonet seems reasonable to me. also this repo seems to already be in the react-dropzone org. Do you mean to move this code into react-dropzone directly?

[okonet]

I moved the repo to the org after I mentioned it. Feel free to move the code along but in this case we might want to create a monorepo structure to accommodate other packages as well?

[gfx]

IMO I don't like monorepo because its version-to-version diffs are hard to understand.

[gfx]

ping

[okonet]

I’m not sure if that should be release as a major or minor version. Thoughts?

[gfx]

Neither am I, but if I were the product owner I'd bump the major version because some users are required to change their application code.

[rxmarbles]

I would agree with a major bump since it could be a breaking change for consuming apps

[okonet]

Okay in this case could you please rename the commit and include the breaking change message according to semantic versioning convention?

[gfx]

Marked it as BREAKING CHANGE both in the PR title and the commit messages. Is it okay?

[okonet]

I’ve adapted the commit message during the merge to comply semantic-versioning. Hopefully it’s going to be released as a major version. Thanks!

[gfx]

Thanks!

[okonet]

Not sure what's going on but travis CI can't trigger semantic release anymore. Can someone investigate? It says 403 but Im not sure what to do.

[rxmarbles]

@okonet I'll take a look when I have some free time. Hopefully today.

[github-actions]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀