pod install fail on RN 0.70.x & New Arch

[retyui]

What happened?

install_modules_dependencies available in rn 0.71+

RCT_NEW_ARCH_ENABLED=1 npx pod-install


[!] Invalid `Podfile` file: 
[!] Invalid `RNCAsyncStorage.podspec` file: undefined method `install_modules_dependencies' for Pod:Module.

 #  from /Users/i/tmp/Rn70New/node_modules/@react-native-async-storage/async-storage/RNCAsyncStorage.podspec:29
 #  -------------------------------------------
 #  
 >      install_modules_dependencies(s)
 #    else
 #  -------------------------------------------

Version

1.19.1

What platforms are you seeing this issue on?

• Android
• iOS
• macOS
• Windows
• web

System Information

System:
    OS: macOS 13.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 8.00 GB / 32.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 18.17.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.7.2 - /opt/homebrew/bin/npm
    Watchman: 2023.07.10.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: Flamingo 2022.2.1 Patch 2 Flamingo 2022.2.1 Patch 2
    Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.19 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0 
    react-native: 0.70.13 => 0.70.13 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to Reproduce

cd MyRn70
yarn add @react-native-async-storage/async-storage
RCT_NEW_ARCH_ENABLED=1 npx pod-install

[retyui]

create-react-native-library the template with backward compatibility

  # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
  # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
  if respond_to?(:install_modules_dependencies, true)
    install_modules_dependencies(s)
  else
  s.dependency "React-Core"

  # Don't install the dependencies when we run `pod install` in the old architecture.
  if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
    s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
    s.pod_target_xcconfig    = {
        "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
        "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
        "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
    }
    s.dependency "React-Codegen"
    s.dependency "RCT-Folly"
    s.dependency "RCTRequired"
    s.dependency "RCTTypeSafety"
    s.dependency "ReactCommon/turbomodule/core"
   end
  end  

[krizzu]

@tido64 I think we should get this in for backward compatibility? Or is there something I'm missing?

[tido64]

@tido64 I think we should get this in for backward compatibility? Or is there something I'm missing?

We should. I just haven't had time for this. 😕

[retyui]

@tido64 fixed in #1004

[AsyncStorageBot]

🎉 This issue has been resolved in version 1.19.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀