Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more gradle properties #343

Merged
merged 4 commits into from
Mar 15, 2018
Merged

feat: add more gradle properties #343

merged 4 commits into from
Mar 15, 2018

Conversation

christocracy
Copy link
Contributor

Description

Adding a gradle property googlePlayServicesVersion is an excellent idea but no need to stop there! This PR simply adds three extra properties:

  • compileSdkVersion
  • buildToolsVersion
  • targetSdkVersion

Compatibility

OS Implemented
iOS n/a
Android
Windows n/a

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I added the documentation in README.md.
  • I mentionned this change in CHANGELOG.md.

Update `compileSdkVersion`, `buildToolsVersion`, `targetSdkVersion`
…idea. This simply expands on this idea with gradle properties compileSdkVersion, buildToolsVersion, targetSdkVersion.
@machour
Copy link
Contributor

machour commented Mar 1, 2018

This is great @christocracy, thank you!

@machour machour changed the title Add gradle properties feat: add more gradle properties Mar 15, 2018
@machour machour merged commit e2c877f into react-native-device-info:master Mar 15, 2018
@machour
Copy link
Contributor

machour commented Mar 15, 2018

Released in 0.21.0, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants