Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox issue with onBlur #4

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

feaber
Copy link
Contributor

@feaber feaber commented Mar 23, 2018

I found an issue on Firefox.

onBlur event is triggered instantly after onClick event for basic input editor.
The issue is better described here: https://tirdadc.github.io/blog/2015/06/11/react-dot-js-firefox-issue-with-onblur/

My React version is: 15.6.1

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          49     53    +4     
  Branches       20     22    +2     
=====================================
+ Hits           49     53    +4
Impacted Files Coverage Δ
src/input.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0019c97...4722fc8. Read the comment docs.

@feaber feaber force-pushed the fix_firefox_issue_with_onblur branch from eca2bab to 4722fc8 Compare March 23, 2018 12:30
@bebraw bebraw merged commit 001aae2 into reactabular:master Apr 5, 2018
@bebraw
Copy link
Member

bebraw commented Apr 5, 2018

Included in 6.4.1.

Sorry for the late merge. I completely forgot the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants