Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSR #619

Merged
merged 3 commits into from
May 6, 2020
Merged

Support SSR #619

merged 3 commits into from
May 6, 2020

Conversation

perrin4869
Copy link
Contributor

Fixes #618 and adds regression tests to make sure the lib loads in node environment

src/Transition.js Outdated Show resolved Hide resolved
nodeRef: PropTypes.shape({
current: typeof Element === 'undefined'
? PropTypes.any
: PropTypes.instanceOf(Element)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not rely on "Element" for this prop-type? My concern is equivalent to merceyz/typescript-to-proptypes#3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem can be noticed on mui/material-ui#21858 (comment).

@jquense jquense merged commit 2722bb6 into reactjs:master May 6, 2020
jquense pushed a commit that referenced this pull request May 6, 2020
## [4.4.1](v4.4.0...v4.4.1) (2020-05-06)

### Bug Fixes

* transition SSR ([#619](#619)) ([2722bb6](2722bb6))
@jquense
Copy link
Collaborator

jquense commented May 6, 2020

🎉 This PR is included in version 4.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR in 4.4.0 crashes
3 participants