Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tool bar" or "Dashboard" for addons #53

Open
humitos opened this issue Apr 17, 2023 · 4 comments
Open

"Tool bar" or "Dashboard" for addons #53

humitos opened this issue Apr 17, 2023 · 4 comments
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Apr 17, 2023

We have been talking about a way, as a reader, to Enable/Disable addons. There are situations where it would be pretty useful to disable doc-diff, for example.

I'd like to propose to decouple this interaction from the flyout if possible 1. Right now, the flyout serves its own purpose showing published versions, offline format links and others.

I was thinking we probably want something more similar to "Django Debug Toolbar" for this purpose:

Collapsed Expanded
Screenshot_2023-04-17_15-59-37 Screenshot_2023-04-17_15-59-50

Note that something simple like this could already serve our own purpose as well, since we could activate/de-activate addons via checkboxes, similar to what "Django Debug Toolbar" does. We could do a PoC creating a <readthedocs-toolbar> element with some simple checkboxes and see how it goes.

Also, besides Enable/Disable addons, what other UX components this toolbar/dashboard could be useful for?

In any case, I'm opening this issue here to start collecting ideas that people may already have, discuss them, and build a quick PoC that we can start testing out.

Footnotes

  1. Maybe, what we need here is to re-think the flyout completely again and re-design it 🤔 . However, that will take a lot more time than a PoC, I'd guess 😄

@humitos humitos added the Improvement Minor improvement to code label Apr 17, 2023
@humitos
Copy link
Member Author

humitos commented Apr 19, 2023

There are other features we have talked about some time about that are not "Enable/Disable" things that we could consider adding here as well. I just found that we talked about "Share this page" link on RTD4B that automatically generates a secret link to that page: https://github.com/readthedocs/readthedocs-corporate/issues/189

@humitos
Copy link
Member Author

humitos commented May 1, 2023

After talking with Eric at PyCon and thinking more about this, I'm imagining there is going to be a new flyout completely redesigned that will host all these addons.

Similar to what we currently have, but not natively integrated with the theme, always visible and showing only the Read the Docs logo when collapsed 1. I think this are key properties that Read the Docs should provide as a hosting platform so all the readers have exact the same experience when surfing documentation at Read the Docs.

Even if authors integrate our addons in a "better way", we will still always provide our own flyout because the user will find all the addons there and it will always look the same -- no matter what's the theme/doctool the original author is using to build their site. This is a vague example of what I'm thinking about:

Flyout bottom right Flyout right
Screenshot_2023-05-01_14-27-43 flyout-right

Considering there is pretty common to have 3-columns themes and different layouts, we should allow some type of configuration to decide what's the position of this widget: top-left, top-right, bottom-left, bottom-right and similar ones that will look better depending on theme itself.

Footnotes

  1. no version will be shown there (e.g. v:stable) -- that's an integration point the theme author should make prominent in the documentation page if they want.

@humitos
Copy link
Member Author

humitos commented Jul 11, 2023

When working on this issue, we need to consider how we want to expose multiple PDFs per version here as well. See readthedocs/readthedocs.org#2045

@ericholscher
Copy link
Member

Example netlify preview: https://deploy-preview-522--new-eslint.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants