Docdiff: initial work to toggle enabled/disabled #63
Conversation
|
I added a smaller example in the
|
- copy the code from doc-diff repository into this client directly. - create a small example at http://localhost:8000/docdiff.html - automatically inject document/global styles
humitos
force-pushed
the
humitos/docdiff
branch
from
2d290d4
to
f00cdd8
Compare
Decide whether or not inject our own styles into the document. They are injected by default, but users can disable it if they want and declare their own `.doc-diff-*` classes.
|
Note that I'm not putting this anywhere in the page automatically for now. I think this will probably be part of #53 instead. |
Since we are not ready for the new flyout yet and we decided to copy the same flyout we currently have in the new implementation as an addon first, I will hide the checkbox for now and I will add a hotkey to enable/disable instead. That way we can deploy it easily without breaking any UI layout and users can start testing it. |
…client into humitos/docdiff
|
I've used
|
|
I'd like to have a review here so we can merge it and start testing it in our projects at least. |
I reverted this decision and use single-stroke |
|
Just a note here for now, but I could see this implementation drifting closer to either a multiposition slider, pair of toggle bars, or even just a dropdown instead (I lean towards this). There are a few modes that I'm finding useful, depending on the pull request contents:
This doesn't need to affect the direction here yet, but will be something we want to consider in the future. Just noting so we don't cement too much of our implementation around a single, binary toggle bar. For the purpose of turning the diff off, this likely works fine for now. |
|
I'm going to merge this because it's working fine. The only way to discover this feature right now is by hitting We can easily disable from the API response if we notice it breaks for some reason. |
Closes #62
Closes #23
Closes #11