Skip to content

Commit

Permalink
Build: use a setting to define the Docker image for the clone step (#…
Browse files Browse the repository at this point in the history
…10555)

* Build: use a setting to define the Docker image for the clone step

It also updates the image to use Ubuntu 22.04 LTS.

* Update readthedocs/settings/base.py

Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>

---------

Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
  • Loading branch information
humitos and ericholscher authored Jul 24, 2023
1 parent de8f94d commit 28274b4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 1 addition & 3 deletions readthedocs/doc_builder/director.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,7 @@ def create_vcs_environment(self):
version=self.data.version,
build=self.data.build,
environment=self.get_vcs_env_vars(),
# Force the ``container_image`` to use one that has the latest
# ca-certificate package which is compatible with Lets Encrypt
container_image=settings.RTD_DOCKER_BUILD_SETTINGS["os"]["ubuntu-20.04"],
container_image=settings.RTD_DOCKER_CLONE_IMAGE,
api_client=self.data.api_client,
)

Expand Down
3 changes: 3 additions & 0 deletions readthedocs/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,9 @@ def TEMPLATES(self):
}
# Always point to the latest stable release.
RTD_DOCKER_BUILD_SETTINGS['tools']['python']['3'] = RTD_DOCKER_BUILD_SETTINGS['tools']['python']['3.11']
# This is used for the image used to clone the users repo,
# since we can't read their config file image choice before cloning
RTD_DOCKER_CLONE_IMAGE = RTD_DOCKER_BUILD_SETTINGS["os"]["ubuntu-22.04"],

def _get_docker_memory_limit(self):
try:
Expand Down

0 comments on commit 28274b4

Please sign in to comment.