Skip to content

Commit

Permalink
Build tools: run asdf version from inside the container (#10575)
Browse files Browse the repository at this point in the history
It was running it from the host and failing on CircleCI because it's not
installed there.

Also, when running it locally it was showing the asdf version from the host
instead from the container, where we are compiling these versions.
  • Loading branch information
humitos authored Jul 27, 2023
1 parent 93b77dc commit d203a73
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scripts/compile_version_upload_s3.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
CONTAINER_ID=$(docker run --user docs --rm --detach --volume ${SCRIPT_DIR}/python-build.diff:/tmp/python-build.diff readthedocs/build:$OS sleep $SLEEP)
echo "Running all the commands in Docker container: $CONTAINER_ID"

echo "asdf version: $(asdf version)"
# Run "asdf version" from inside the container
echo -n 'asdf version: '
docker exec --user root $CONTAINER_ID asdf version

# Install the tool version requested
if [[ $TOOL == "python" ]]
Expand Down

0 comments on commit d203a73

Please sign in to comment.