Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: use django-safemigrations for safer deploys #10964

Closed
humitos opened this issue Dec 20, 2023 · 1 comment · Fixed by #11087
Closed

DB: use django-safemigrations for safer deploys #10964

humitos opened this issue Dec 20, 2023 · 1 comment · Fixed by #11087
Assignees
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required Operations Operations or server issue

Comments

@humitos
Copy link
Member

humitos commented Dec 20, 2023

I've found the package https://github.com/aspiredu/django-safemigrate that helps making deployments safer by labeling migrations to be run before deploy, after deploy or always. This is essentially what we do via note cards in our GH release project. However, we need to do this manually at deploy time and it's easy to make mistake here.

I want to propose using this package and get the habit to label the migrations when developing so we make our deploys simpler and easier. Besides, we can adjust our deploy script to be more automated, without the need to jump into web-extra to run these migrations before continuing with the deployment.

@humitos humitos added Improvement Minor improvement to code Operations Operations or server issue Needed: design decision A core team decision is required labels Dec 20, 2023
@humitos
Copy link
Member Author

humitos commented Jan 8, 2024

We talked a little about this in one of our calls and we said it's a good pattern and idea to implement for safer deploys. We don't have a ETA for this, but it shouldn't be hard to put it under one of the following sprints.

stsewd added a commit that referenced this issue Feb 1, 2024
stsewd added a commit that referenced this issue Feb 14, 2024
* Use django-safemigrate for migrations

Closes #10964

* Add to toc

* Fix migration

* Fix fixtures

* Update common

* Fix package name

* Updates from review

* Update common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required Operations Operations or server issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants
@humitos @stsewd and others