Build: log when a build is reset #9015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the build worker is killed for any reason, as we are using `ACKS_LATE`, the build task will be picked by another worker and re-executed. When that happens, we detect that the `Build` object already has some commands saved on it and we delete those commands to start again from scratch. This commit just adds a log line to be aware how often this situation happens in production and be able to make other decisions.
ericholscher
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the build worker is killed for any reason, as we are using
ACKS_LATE, thebuild task will be picked by another worker and re-executed.
When that happens, we detect that the
Buildobject already has some commandssaved on it and we delete those commands to start again from scratch.
This commit just adds a log line to be aware how often this situation happens in
production and be able to make other decisions.