Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: remove DEDUPLICATE_BUILDS feature #9591

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 8, 2022

With the introduction of CANCEL_OLD_BUILDS we are moving away from the DEDUPLICATE_BUILDS feature since these scenario is managed in a better way by the new feature.

Closes #7306
Related #9549


📚 Documentation previews 📚

With the introduction of `CANCEL_OLD_BUILDS` we are moving away from the
`DEDUPLICATE_BUILDS` feature since these scenario is managed in a better way by
the new feature.

Closes #7306
Related #9549
@humitos humitos marked this pull request as ready for review October 5, 2022 11:04
@humitos humitos requested a review from a team as a code owner October 5, 2022 11:04
@humitos humitos requested a review from stsewd October 5, 2022 11:04
@humitos
Copy link
Member Author

humitos commented Oct 5, 2022

@stsewd I'm confused. Didn't we already fix this? 🤔

WARNINGS:
?: (urls.W001) Your URL pattern '^api/v2/search/$' uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs.

"checks" are failing because of this.

@stsewd
Copy link
Member

stsewd commented Oct 5, 2022

@stsewd I'm confused. Didn't we already fix this? thinking

WARNINGS:
?: (urls.W001) Your URL pattern '^api/v2/search/$' uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs.

"checks" are failing because of this.

Haven't fixed it, but that's a warning (the url still works), the error you get is because you have pending migrations

Migrations for 'builds':
readthedocs/builds/migrations/0045_alter_build_status.py
- Alter field status on buil

@humitos
Copy link
Member Author

humitos commented Oct 6, 2022

@stsewd thanks! I update the PR with the missing migration. I think it's ready to merge.

The only part that had to be removed originally was the ".exclude()".
readthedocs/core/utils/__init__.py Outdated Show resolved Hide resolved
@humitos humitos merged commit bb9dd8b into main Oct 6, 2022
@humitos humitos deleted the humitos/builds/remove-duplicated-builds branch October 6, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants