Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-latin characters in parser #4558

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Support non-latin characters in parser #4558

merged 3 commits into from
Mar 25, 2021

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Mar 24, 2021

What, How & Why?

Fixes #4467

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

@jedelbo jedelbo requested a review from ironage March 24, 2021 14:55
bmunkholm
bmunkholm reviewed Mar 24, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jedelbo jedelbo requested a review from ironage March 24, 2021 17:26
ironage
ironage approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedelbo jedelbo merged commit b692bc2 into v11 Mar 25, 2021
@jedelbo jedelbo deleted the je/parser-non-latin branch March 25, 2021 06:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmelchior cmelchior cmelchior left review comments

@bmunkholm bmunkholm bmunkholm left review comments

@ironage ironage ironage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jedelbo @cmelchior @bmunkholm @ironage