Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

update library versions, remove opentracing #189

Merged
merged 4 commits into from
Nov 25, 2022
Merged

update library versions, remove opentracing #189

merged 4 commits into from
Nov 25, 2022

Conversation

cwuthe
Copy link
Contributor

@cwuthe cwuthe commented Nov 25, 2022

TODO:

  • create new release
  • create CI test

@cwuthe cwuthe requested a review from a team November 25, 2022 10:29
@cwuthe
Copy link
Contributor Author

cwuthe commented Nov 25, 2022

Hey, Petar just pointed out, that what I do locally (build archtype, create dummy silo, compile it and run the silo) could be a CI test (to make sure this archtype actually generates a runnable silo).

Could you point me in the right way on how to do this?
What I basically do is:

archtypeVersion=15.6.1-SNAPSHOT
siloName="archetype-test-silo"
artifactId=${siloName%%-silo}
domain=${${siloName%%-silo}//-/}
databaseSchema=${siloName//-/_}
secret=$(pwgen 16 1)
secretHash=$(php -r "print(substr_replace(password_hash('$secret', PASSWORD_BCRYPT),'\$2a$',0,4). PHP_EOL);")

echo $archtypeVersion $siloName $artifactId $domain $databaseSchema $secret $secretHash

mvn archetype:generate \
    -DarchetypeGroupId=com.rebuy.archetypes \
    -DarchetypeArtifactId=rebuy-silo-archetype \
    -DarchetypeVersion=$archtypeVersion \
    -DgroupId=com.rebuy.service \
    -DartifactId=$artifactId \
    -DprojectName=$siloName \
    -Dpackage=com.rebuy.service.$domain \
    -Dversion=1.0.0-SNAPSHOT \
    -DarchetypeRepository=https://nexus.rebuy.dev/repository/maven-releases \
    -DdatabaseSchema=$databaseSchema \
    -DclientSecret=$secret

echo "If you want to generate a client, this is your hashed secret: "$secretHash

cd archtype-silo
mvn clean package
cd silo
mvn spring-boot:run

And check that it's starting ok.

@svenwltr
Copy link
Member

We do not have proper documentation about this, but you basically need to write a GitHub Action for this.

To make it run on our infrastructure, if is necessary to define the target: https://github.com/rebuy-de/github-actions-workflows/blob/main/.github/workflows/spring-boot-pipeline.yaml#L53

This repo contains our common github actions code: https://github.com/rebuy-de/github-actions-workflows

Unfortunately our GitHub Actions Expert is on vacation today.

@cwuthe
Copy link
Contributor Author

cwuthe commented Nov 25, 2022

Ok, thanks sven - I'll note it down for next friday then with @der-eismann I already prepared everthing and, in turn, migrated to junit5/jupiter

@cwuthe cwuthe merged commit e5c6f28 into master Nov 25, 2022
@cwuthe cwuthe deleted the update-libs branch November 25, 2022 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants