Default APIVersion and Kind for objects #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Andrews <scott@andrews.me>
scothis
commented
Jun 10, 2024
| @@ -477,9 +477,6 @@ func (c *copyMethodMaker) generateJSONMethodsFor(die Die) { | |||
|
|
|||
| c.Linef("") | |||
| c.Linef("func (d *%s) UnmarshalJSON(b []byte) error {", die.Type) | |||
| c.Linef(" if d == %s {", die.Blank) | |||
There was a problem hiding this comment.
Removing this check because the blank is always immutable. Even in this case, the retained message below is better because a copy of an immutable die is still immutable.
mamachanko
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the APIVersion and Kind isn't necessary for typed objects, it is essential for unstructured objects. Set the default values on object dies by calling
d.DieDefaultTypeMeta(). This behavior is opt-in to avoid mass changes to existing objects.