[CodeQuality] Skip no @Property doc on DynamicDocBlockPropertyToNativ…

…ePropertyRector (#6380)

rules-tests/CodeQuality/Rector/Class_/DynamicDocBlockPropertyToNativePropertyRector/Fixture/skip_no_property_doc.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\DynamicDocBlockPropertyToNativePropertyRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\Class_\DynamicDocBlockPropertyToNativePropertyRector\Source\SomeDependency;
+
+/**
+ * @see SomeDependency
+ */
+#[\AllowDynamicProperties]
+final class SkipNoPropertyDoc
+{
+    public function run(): void
+    {
+        $this->someDependency = new SomeDependency();
+    }
+}

rules/CodeQuality/Rector/Class_/DynamicDocBlockPropertyToNativePropertyRector.php

@@ -101,29 +101,34 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        // 1. remove dynamic attribute, most likely any
-        $node->attrGroups = [];
-
         // 2. add defined @property explicitly
         $classPhpDocInfo = $this->phpDocInfoFactory->createFromNode($node);
-        if ($classPhpDocInfo instanceof PhpDocInfo) {
-            $propertyPhpDocTagNodes = $classPhpDocInfo->getTagsByName('property');
+        if (! $classPhpDocInfo instanceof PhpDocInfo) {
+            return null;
+        }
 
-            $newProperties = $this->createNewPropertyFromPropertyTagValueNodes($propertyPhpDocTagNodes, $node);
+        $propertyPhpDocTagNodes = $classPhpDocInfo->getTagsByName('property');
+        if ($propertyPhpDocTagNodes === []) {
+            return null;
+        }
 
-            // remove property tags
-            foreach ($propertyPhpDocTagNodes as $propertyPhpDocTagNode) {
-                // remove from docblock
-                $this->phpDocTagRemover->removeTagValueFromNode($classPhpDocInfo, $propertyPhpDocTagNode);
-            }
+        // 1. remove dynamic attribute, most likely any
+        $node->attrGroups = [];
 
-            // merge new properties to start of the file
-            $node->stmts = array_merge($newProperties, $node->stmts);
+        $newProperties = $this->createNewPropertyFromPropertyTagValueNodes($propertyPhpDocTagNodes, $node);
 
-            // update doc info
-            $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
+        // remove property tags
+        foreach ($propertyPhpDocTagNodes as $propertyPhpDocTagNode) {
+            // remove from docblock
+            $this->phpDocTagRemover->removeTagValueFromNode($classPhpDocInfo, $propertyPhpDocTagNode);
         }
 
+        // merge new properties to start of the file
+        $node->stmts = array_merge($newProperties, $node->stmts);
+
+        // update doc info
+        $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
+
         return $node;
     }