Fix missing stmt on adding a new node #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
downgrade-covariant-mix-bug
branch
from
f3592ae
to
d0f6a2d
Compare
TomasVotruba
commented
May 7, 2021
| reset($all); | ||
| if (($inputArgument = isset($all[$key = key($all)]) ? $all[$key = key($all)] : null) && 'command' === $inputArgument->getName()) { | ||
| } | ||
| } |
There was a problem hiding this comment.
@samsonasik BTW, today I find one nasty bug in Rector.
This might be one reason why the downgrade rules were not working sometimes.
This code previously failed and missed all the removed types. Causing missmatch:
TomasVotruba
commented
May 7, 2021
Comment on lines
+145
to
+149
| $currentStmt = $node->getAttribute(AttributeKey::CURRENT_STATEMENT); | ||
| if ($currentStmt instanceof Stmt) { | ||
| return spl_object_hash($currentStmt); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the fix that helped. It might require more parent node/stmt connecting fixes though
TomasVotruba
changed the title
TomasVotruba
commented
May 7, 2021
Comment on lines
-141
to
-142
| if ($foundNode === null) { | ||
| $foundNode = $node; |
There was a problem hiding this comment.
Not sure why I put this here (probably not knowing difference between Stmt and Expr in that time), but it was asking for a bug 🤔
If it's null, it has to fail
TomasVotruba
added a commit
that referenced
this pull request
Oct 15, 2024
rectorphp/rector-src@7be438b [DeadCode] Skip non FullyQualified property type on RemoveTypedPropertyNonMockDocblockRector (#6383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.