-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tiered Unit Pricing Labels #790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2023
douglaslise
force-pushed
the
fix-tiered-unit-price-labels
branch
from
February 21, 2023 16:20
40dece1
to
640471c
Compare
douglaslise
force-pushed
the
fix-tiered-unit-price-labels
branch
from
February 21, 2023 19:48
640471c
to
caf5512
Compare
douglaslise
force-pushed
the
fix-tiered-unit-price-labels
branch
from
February 22, 2023 17:05
fead5b7
to
19ad630
Compare
douglaslise
force-pushed
the
fix-tiered-unit-price-labels
branch
from
February 22, 2023 17:07
19ad630
to
6e8fab7
Compare
epagerecurly
approved these changes
Feb 22, 2023
chrissrogers
approved these changes
Feb 22, 2023
chrissrogers
approved these changes
Feb 27, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Feb 28, 2023
[Full Changelog](v4.22.8...v4.22.9) **Merged Pull Requests** - Installing `httplib2` and `crcmod` as needed by `gsutil` in the last build step [#791](#791) ([douglaslise](https://github.com/douglaslise)) - Fix Tiered Unit Pricing Labels [#790](#790) ([douglaslise](https://github.com/douglaslise)) - [feat][apple-pay] send hostname to server and specify applicationData [#788](#788) ([cbarton](https://github.com/cbarton)) ##### Minified MD5 Checksum ``` c18e7771616de48fb52212d0e77fad84 ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` mdUIUHUE3I2tGHLncdU8h2i9WkpS1QXV37Lqi2sv9EAJilkQWKDpOH7cx9xpII7N ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes addressed in this PR:
Fix prices calculated for each tiered addon, now considering the
quantity
amount for inputs usingdata-recurly="addon_price"
.Before this change the price for addons in these points were being calculated using the largest tier:
subscription.price.base.addons['addon-code']
subscription.price.addons['addon-code']
Fix total and subtotal calculation when having multiple addons for the same subscription