Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tiered Unit Pricing Labels #790

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Conversation

douglaslise
Copy link
Contributor

@douglaslise douglaslise commented Feb 21, 2023

Fixes addressed in this PR:

  • Fix prices calculated for each tiered addon, now considering the quantity amount for inputs using data-recurly="addon_price".
    Before this change the price for addons in these points were being calculated using the largest tier:

    • subscription.price.base.addons['addon-code']
    • subscription.price.addons['addon-code']
  • Fix total and subtotal calculation when having multiple addons for the same subscription

@douglaslise douglaslise changed the base branch from master to fix-httplib2-build February 21, 2023 16:20
@douglaslise douglaslise marked this pull request as ready for review February 21, 2023 16:21
Base automatically changed from fix-httplib2-build to master February 21, 2023 19:43
@coveralls
Copy link

coveralls commented Feb 21, 2023

Coverage Status

Coverage: 92.691% (+0.005%) from 92.686% when pulling dd205ed on fix-tiered-unit-price-labels into bf29c58 on master.

@chrissrogers chrissrogers merged commit c307123 into master Feb 27, 2023
@chrissrogers chrissrogers deleted the fix-tiered-unit-price-labels branch February 27, 2023 18:13
recurly-integrations pushed a commit that referenced this pull request Feb 28, 2023
[Full Changelog](v4.22.8...v4.22.9)

**Merged Pull Requests**

- Installing `httplib2` and `crcmod` as needed by `gsutil` in the last build step [#791](#791) ([douglaslise](https://github.com/douglaslise))
- Fix Tiered Unit Pricing Labels [#790](#790) ([douglaslise](https://github.com/douglaslise))
- [feat][apple-pay] send hostname to server and specify applicationData [#788](#788) ([cbarton](https://github.com/cbarton))

##### Minified MD5 Checksum
```
c18e7771616de48fb52212d0e77fad84 ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
mdUIUHUE3I2tGHLncdU8h2i9WkpS1QXV37Lqi2sv9EAJilkQWKDpOH7cx9xpII7N
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants