Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basic-spring-boot pipeline to use namespace names defined via applier #151

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

bparry02
Copy link
Contributor

@bparry02 bparry02 commented Aug 1, 2020

What does this PR do?

Updates to allow the user to change the namespace names of the -build, -dev, -stage, and -prod namespaces. Before this PR, the Jenkinsfile would attempt to derive the application and build names from the -build namespace name, which would fail if applier namespace variables had been changed.

This PR does not address that namespace names are still defined in two places: .openshift/projects/projects.yml and .applier/group_vars/seed-hosts.yml.

How should this be tested?

  1. Update the project request resources in .openshift/projects/projects.yml by prepending test- to all four names
  2. Run the applier with additional command line vars to override the default namespace names, and refer to the branch in this PR:
ansible-playbook -i ./.applier/ galaxy/openshift-applier/playbooks/openshift-cluster-seed.yml -e sb_build_namespace=test-basic-spring-boot-build -e sb_dev_namespace=test-basic-spring-boot-dev -e sb_stage_namespace=test-basic-spring-boot-stage -e sb_prod_namespace=test-basic-spring-boot-prod -e sb_source_repository_url="https://github.com/bparry02/container-pipelines.git" -e sb_source_repository_ref=135-namespace-names
  1. Verify the pipeline ran successfully

Is there a relevant Issue open for this?

Yes, resolves #135

Who would you like to review this?

cc: @redhat-cop/containers-approvers

Set namespace names used in the pipeline via env vars.
This allows names to be changed in the applier config.
@bparry02
Copy link
Contributor Author

bparry02 commented Aug 2, 2020

/assign @garethahealy

@garethahealy
Copy link
Contributor

/lgtm
/approve

@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethahealy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit 6f786dc into redhat-cop:master Sep 28, 2020
@bparry02 bparry02 deleted the 135-namespace-names branch September 30, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

basic-spring-boot pipeline image build fails when build namespace name changes
3 participants