Deployment of Hygieia to OpenShift #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etsauer
changed the title
1 similar comment
pcarney8
reviewed
Dec 11, 2018
| @@ -0,0 +1,76 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
is this the same as the new build-docker-generic template?
There was a problem hiding this comment.
probably, but since we currently don't have that in a release, I'd rather no point to it yet.
| @@ -0,0 +1,17 @@ | |||
| --- | |||
There was a problem hiding this comment.
Can we delete this and point to: https://raw.githubusercontent.com/redhat-cop/cluster-lifecycle/v3.9.0/files/projectrequest/template.yml instead?
need to add NAMESPACE_DISPLAY_NAME: "{{ namespace }}" to params if using it.
sabre1041
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
Describe the contents of the PR
How do we test this?
Provide commands/steps to test this PR.
cc: @redhat-cop/containerize-it