Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins-slave-ansible-stacks #16

Merged
merged 11 commits into from
Jan 28, 2017
Merged

Add jenkins-slave-ansible-stacks #16

merged 11 commits into from
Jan 28, 2017

Conversation

jkupferer
Copy link
Contributor

What is this PR About?

This pull request adds a jenkins slave image for using ansible-stacks from a jenkins slave. This came out of work with a recent engagement where we provisioned projects and resources in OpenShift.

How do we test this?

See the README.md for instantiating the template to build the image. For example:

oc process -f templates/jenkins-slave-ansible-stacks-template.json \
-v SOURCE_REPOSITORY_URL=https://github.com/jkupferer/containers-quickstarts.git \
-v SOURCE_REPOSITORY_REF=master \
-v ANSIBLE_YUM_REPO=rhel-7-server-ose-3.3-rpms | oc create -f -

Next run the image in Jenkins with sample code to test. The jenkins service account will need self-provisioner role for the given example to succeed.

@sabre1041
Copy link
Contributor

@jkupferer attempted to run through the PR and ran into a few issues:

  1. Example pipeline needs to include a closing }
  2. No playbook called local-file.yaml exists
  3. It seems this PR is dependent on several PR's from being accepted/merged at ansible-stacks

Also, do we want to set default environment variables? Defining them within a BuildConfig as is done currently should overwrite the default value?

Previously the Dockerfile exclusively relied upon the template to set values for
ANSIBLE_YUM_REPO, ANSIBLE_STACKS_SOURCE_REPOSITORY_URL, and ANSIBLE_STACKS_SOURCE_REPOSITORY_REF
Fix missing closing curly bracket.
Add creation of local playbook.
@jkupferer
Copy link
Contributor Author

Fixed up the missing closing curly.
Removed need for local-file.yaml.
Remove dependency in example in README for ansible-stacks PR for no-login feature.
Added default values to environment variables in the Dockerfile so that it can be simply built and tested outside of OpenShift.

@sabre1041
Copy link
Contributor

lgtm

@sabre1041 sabre1041 merged commit 98bb172 into redhat-cop:master Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants