-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipa #217
Add ipa #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job for the first iteration. A few minor comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @tylerauerbeck, left a comment/question inline.
@oybed @makentenza So after trying to run this more than once (without deleting anything) the applier runs into an issue when processing the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial test failed while creating the SA:
failed: [localhost] (item={'oc_path': u''}) => {"changed": true, "cmd": "oc process --local -f https://raw.githubusercontent.com/redhat-cop/openshift-templates/v1.4.5/scc/project-run-anyuid-template.yml -n ipa --param='NAMESPACE=ipa' --param='NAME=ipa' --ignore-unknown-parameters | oc apply -n ipa -f - ", "delta": "0:00:00.389477", "end": "2019-06-19 11:04:24.309862", "failed_when_result": true, "msg": "non-zero return code", "oc_param_file_item": {"oc_path": ""}, "rc": 1, "start": "2019-06-19 11:04:23.920385", "stderr": "Warning: oc apply should be used on resource created by either oc create --save-config or oc apply\nError from server (UnsupportedMediaType): the body of the request was in an unknown format - accepted media types include: application/json-patch+json, application/merge-patch+json", "stderr_lines": ["Warning: oc apply should be used on resource created by either oc create --save-config or oc apply", "Error from server (UnsupportedMediaType): the body of the request was in an unknown format - accepted media types include: application/json-patch+json, application/merge-patch+json"], "stdout": "", "stdout_lines": []}
So @tylerauerbeck for the error you are getting it looks like the template is not correct: That entry should be:
Note the double brackets, as the template is expecting a non-string parameter. Will submit a quick fix for that. |
@tylerauerbeck this should solve the issue: |
@pabrahamsson @oybed Updated and now runs correctly on both OCP v3 and v4 (as long as settings as noted in the README are followed). Feel free to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Unless anbody objects, let's merge so we can move forward with additional work - including follow-up PRs.
What is this PR About?
Adds an applier to deploy ipa-server (Red Hat IdM) on openshift
How do we test this?
Replace the appropriate values in
.applier/group_vars/seed-hosts.yml
and then run:ansible-galaxy install -r requirements.yml -p roles
ansible-playbook -i .applier/ roles/openshift-applier/playbooks/openshift-cluster-seed.yml
cc: @redhat-cop/day-in-the-life @makentenza @oybed @pabrahamsson