Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated apiVersions to fully qualified 4.x compatible #344

Merged
merged 2 commits into from
May 18, 2020
Merged

Updated apiVersions to fully qualified 4.x compatible #344

merged 2 commits into from
May 18, 2020

Conversation

garethahealy
Copy link
Contributor

What is this PR About?

As discussed in CoP meeting. Updates apiVersions to work on 4.x

How do we test this?

Apply the template or run rego tests

cc: @redhat-cop/day-in-the-life

@pabrahamsson pabrahamsson added this to In progress in container-cop-tracks via automation May 18, 2020
@pabrahamsson pabrahamsson self-assigned this May 18, 2020
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @garethahealy this looks good

Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too quick on the approval, there's one tiny change I'd like before we're good to merge

container-cop-tracks automation moved this from In progress to Review in progress May 18, 2020
@redhat-cop-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethahealy, pabrahamsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pabrahamsson
Copy link
Contributor

/lgtm

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit 49c82b0 into redhat-cop:master May 18, 2020
container-cop-tracks automation moved this from Review in progress to Done May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants