s2i-liberty #4

raffaelespazzoli · 2016-09-28T13:30:52Z

No description provided.

etsauer · 2016-09-28T14:42:29Z

s2i-liberty/Dockerfile

+# This image provides a base for building and running WildFly applications.
+# It builds using maven and runs the resulting artifacts on WildFly 10.1.0 Final
+
+FROM websphere-liberty:webProfile7


Is this using a red hat based base or debian?

the builder image can be any. The runtime image is created by IBM based on debian. I changed the user to our standard 1001. I think we want to keep the IBM's provided image as our base image because it increases the chances for our customers that IBM will support it.

etsauer

Overall this looks really nice. Just recommending a few changes to the Documentation.

@sabre1041 please review as well.

etsauer · 2016-09-29T13:00:37Z

s2i-liberty/readme.md

+
+### Environment Specifications
+
+This demo should be run on an installation of OpenShift Enterprise V3.3


Let's change "OpenShift Enterprise" to "OpenShift Container Platform" as that's the official name as of 3.3

etsauer · 2016-09-29T13:01:01Z

s2i-liberty/readme.md

+
+## Setup Instructions
+
+There is no specific requirements necessary for this demonstration. The presenter should have an OpenShift Enterprise 3.3 environment available with access to the public Internet and the OpenShift Command Line Tools installed on their machine.


Again, "OpenShift Container Platform"

etsauer · 2016-09-29T13:01:45Z

s2i-liberty/readme.md

+oc login <OpenShift_Master_API_Address>
+```
+
+Create a new project called *play-demo*


switch "play-demo" for "liberty-demo"

etsauer · 2016-09-29T15:00:31Z

s2i-liberty/readme.md

+The content used to produce the Liberty runtime image can originate from a Git repository. Execute the following command to start a new image build using the git source strategy.:
+
+```
+oc new-build websphere-liberty:webProfile7~https://github.com/raffaelespazzoli/containers-quickstarts --context-dir=s2i-liberty --name=liberty-runtime-s2i --strategy=docker


let's change the git repo name to https://github.com/redhat-cop/containers-quickstarts

etsauer · 2016-09-29T15:06:20Z

s2i-liberty/readme.md

+
+In this example we will use a pre-existing builder image that can build maven based apps: `registry.access.redhat.com/jboss-eap-7/eap70-openshift` 
+
+#### Git Source


So this heading to me implies "Hey let's build an app from source using our liberty base image", which in actuality, this is the step to docker build the base image in OpenShift. I think we should change this heading to "Building the S2I Base Image", and then have a separate "Build from Git" heading that shows the oc new-app command pointing to an application git repo, in addition to the "Binary Build" steps below.

I didn't get this comment. can we talk about it? I applied the other feedback

We can disregard this comment

sabre1041

Reviewed README only. Added some comments to the README. Also recommend changing the name of the file to the capitalize README to conform with conventions.

Looks good otherwise. Only suggestion is a validation step to demonstrate the application was successfully deployed (hit a web page etc)

sabre1041 · 2016-10-06T01:48:57Z

s2i-liberty/readme.md

+
+OpenShift provides several out of the box Source to Image builder images. To support deployments in Liberty, a new s2i builder image will be created to support a simplified deployment to OpenShift. Once the new image is produced, an example application will be deployed. 
+
+We will use the [extended builds approach](https://docs.openshift.org/latest/dev_guide/builds.html#extended-builds).


This should reference the OCP docs instead of origin

https://docs.openshift.com/container-platform/3.3/dev_guide/builds.html#extended-builds

sabre1041 · 2016-10-06T01:50:58Z

s2i-liberty/readme.md

+        - sourcePath: /opt/eap/standalone/deployments/hello-world-war-1.0.0.war
+          destinationDir: artifacts
+```
+notice that the source strategy has two additional sections:


Can we provide this modifications as a patch command that users can easily apply?

sabre1041 · 2016-10-06T01:51:58Z

s2i-liberty/readme.md

+
+### Create a new Application
+
+To demonstrate the usage of the newly created builder and runtime images, a Jee example application will be built and deployed to Liberty using the Source to Image process. 


Capitalize JEE

sabre1041 · 2016-10-06T01:53:22Z

s2i-liberty/readme.md

+The build that was triggered by the `new-app` command can be found by executing the following command:
+
+```
+oc get builds -l=app=play-app


Change to hello-world assuming that is the correct label

sabre1041 · 2016-10-06T01:53:32Z

s2i-liberty/readme.md

+
+* `oc new-app` - OpenShift command to create a a new application
+* `-i=hello-world` - Name of the ImageStream that contains the result of the build config that uses the extended s2i process
+* `--name=play-app` - Name to be applied to the newly created resources


Change to hello-world

sabre1041 · 2016-10-06T01:55:01Z

s2i-liberty/readme.md

+
+## Considerations on http session failover
+
+When liberty is deployed in a cloud environment certain limitation applies as explained in this [document](http://www.ibm.com/support/knowledgecenter/en/SSD28V_8.5.5/com.ibm.websphere.wlp.core.doc/ae/cwlp_paas_restrict.html).


Sentence needs to be cleaned up. "When liberty is deployed in a cloud environment, there are certain limitations that apply as explained in this document"

https://github.com/raffaelespazzoli/containers-quickstarts Conflicts: s2i-liberty/Dockerfile

etsauer · 2016-10-08T16:13:28Z

@raffaelespazzoli this looks much better. However, after I run the oc new-app to create the deployment, the pod gets stuck in a CrashLoop with the following error:

[esauer@localhost containers-quickstarts]$ oc get pods
NAME                            READY     STATUS             RESTARTS   AGE
hello-world-1-build             0/1       Completed          0          14h
hello-world-1-mih0g             0/1       CrashLoopBackOff   2          14h
hello-world-artifacts-1-build   0/1       Completed          0          14h
s2i-liberty-1-build             0/1       Completed          0          14h
[esauer@localhost containers-quickstarts]$ oc logs -f hello-world-1-mih0g
JVMSHRC155E Error copying username into cache name
JVMSHRC686I Failed to startup shared class cache. Continue without using it as -Xshareclasses:nonfatal is specified
CWWKE0005E: The runtime environment could not be launched.
CWWKE0044E: There is no write permission for server directory /opt/ibm/wlp/output/defaultServer

raffaelespazzoli · 2016-10-10T10:46:53Z

@etsauer I tried to reproduce the error, but it works fine with me. Which approach are you trying? Also can you make sure you start from a clean project?

sabre1041 · 2016-10-10T14:38:55Z

@raffaelespazzoli The issue is most likely caused by the relaxed permissions of the Red Hat CDK. By default, all containers are run with the anyuid scc. When I ran through the steps in the PR using the baseline CDK configuration, I was able to launch the container successfully (as it was running with the anyuid scc). When I removed that privilege, with the following command, I hit the same error as @etsauer

oc adm policy remove-scc-from-group anyuid system:authenticated

etsauer · 2016-10-10T17:17:17Z

@sabre1041 what would cause that? the dockerfile uses USER 1001 which should get a proper uuid right?

sabre1041 · 2016-10-10T18:20:53Z

@etsauer no. by default in non-CDK installations, a user is randomly assigned from a range and the UID in the dockerfile is ignored as governed by the restricted scc. In the CDK, all authenticated users are given access to the anyuid scc.

raffaelespazzoli · 2016-10-10T22:23:04Z

I added some instructions to the docker file which should fix the issue.
The image still works for me but I don't have an easily accessible OCP (I'm working on it).
@etsauer do you mind retesting it?

sabre1041 · 2016-10-10T23:43:21Z

@raffaelespazzoli validated latest updates allow container to start up successfully.

README needs to add instructions on how to view the sample application. This requires the service to be exposed and in particular, the correct port (default is 7777, but application is available on 9080). In addition, application is available at /hello-world-war-1.0.0 instead of /

raffaelespazzoli · 2016-10-11T14:08:41Z

@sabre1041 thanks, I addressed the port issue and added instructions on how to verify the application.
I didn't change the context root of the application as that would require a change in the application code which I don't own.

sabre1041 · 2016-10-13T00:13:05Z

@raffaelespazzoli this looks great. Would you be able to squash all of the commits? Then we should be good to merge

sabre1041 · 2016-10-13T00:14:03Z

@etsauer you will need to approve changes before we will eventually be able to merge

Add jenkins collector

raffaelespazzoli added 5 commits September 27, 2016 17:39

s2i-liberty initial commit

1d45bab

fixed repo

3cef661

added readme

04fa257

deleted test directory

dfc8d5a

fixed missing bashang in run command

ea42cbc

etsauer reviewed Sep 28, 2016

View reviewed changes

etsauer requested changes Sep 29, 2016

View reviewed changes

raffaelespazzoli added 2 commits September 30, 2016 07:25

Update readme.md

97d40b5

Update readme.md

12666fa

sabre1041 requested changes Oct 6, 2016

View reviewed changes

raffaelespazzoli added 20 commits October 6, 2016 10:16

added two build approach

23bf58a

added ability to debug liberty

6da266e

added echo statements to build

923ac20

debug port

5f74db7

a

64325ec

d

cb019e4

d

e2bc269

d

b073470

jolokia

c5e6088

improved jolokia

17015a7

run debug

5811643

debug run

1ea2747

run debug

7970be5

debug run

86ad4bf

debug jolokia

3060150

jolokia debug

5deb6e3

jolokia debug

fbf5906

Merge branch 'master' of

2ae50b8

https://github.com/raffaelespazzoli/containers-quickstarts Conflicts: s2i-liberty/Dockerfile

jolokia debug

d5560c3

jolokia debug

a416fb4

raffaelespazzoli added 11 commits October 7, 2016 19:21

jolokia debug

8d34e3f

jolokia debug

24e192c

jolokia debug

2ec145d

no jolokia

57f9d58

improved cohexistance of chained builds and extended build

13c05c5

debug

e7500dd

debug

fd7e11d

fixed readme

67a4a38

readme fixes

a4cf45d

d

ed21fdb

last fix

7dacd1e

correction for allowing a random user in root group to run the image

2a0cb63

raffaelespazzoli added 3 commits October 11, 2016 09:58

added application verification

909ec16

fixed the md

e29a787

fix

11863f1

etsauer approved these changes Oct 13, 2016

View reviewed changes

sabre1041 merged commit d3247b2 into redhat-cop:master Oct 14, 2016

pcarney8 pushed a commit to pcarney8/containers-quickstarts that referenced this pull request Dec 7, 2018

Merge pull request redhat-cop#4 from tomgeorge/add-jenkins-collector

6d9f798

Add jenkins collector

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

s2i-liberty #4

s2i-liberty #4

raffaelespazzoli commented Sep 28, 2016

etsauer Sep 28, 2016

raffaelespazzoli Sep 28, 2016

etsauer left a comment

etsauer Sep 29, 2016

etsauer Sep 29, 2016

etsauer Sep 29, 2016

etsauer Sep 29, 2016

etsauer Sep 29, 2016

raffaelespazzoli Sep 30, 2016

etsauer Oct 5, 2016

sabre1041 left a comment

sabre1041 Oct 6, 2016

sabre1041 Oct 6, 2016 •

edited

Loading

sabre1041 Oct 6, 2016

sabre1041 Oct 6, 2016 •

edited

Loading

sabre1041 Oct 6, 2016

sabre1041 Oct 6, 2016

etsauer commented Oct 8, 2016

raffaelespazzoli commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

etsauer commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

raffaelespazzoli commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

raffaelespazzoli commented Oct 11, 2016

sabre1041 commented Oct 13, 2016

sabre1041 commented Oct 13, 2016


		### Environment Specifications

		This demo should be run on an installation of OpenShift Enterprise V3.3


		## Setup Instructions

		There is no specific requirements necessary for this demonstration. The presenter should have an OpenShift Enterprise 3.3 environment available with access to the public Internet and the OpenShift Command Line Tools installed on their machine.


		In this example we will use a pre-existing builder image that can build maven based apps: `registry.access.redhat.com/jboss-eap-7/eap70-openshift`

		#### Git Source


		OpenShift provides several out of the box Source to Image builder images. To support deployments in Liberty, a new s2i builder image will be created to support a simplified deployment to OpenShift. Once the new image is produced, an example application will be deployed.

		We will use the [extended builds approach](https://docs.openshift.org/latest/dev_guide/builds.html#extended-builds).


		### Create a new Application

		To demonstrate the usage of the newly created builder and runtime images, a Jee example application will be built and deployed to Liberty using the Source to Image process.


		## Considerations on http session failover

		When liberty is deployed in a cloud environment certain limitation applies as explained in this [document](http://www.ibm.com/support/knowledgecenter/en/SSD28V_8.5.5/com.ibm.websphere.wlp.core.doc/ae/cwlp_paas_restrict.html).

s2i-liberty #4

s2i-liberty #4

Conversation

raffaelespazzoli commented Sep 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etsauer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabre1041 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabre1041 Oct 6, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabre1041 Oct 6, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etsauer commented Oct 8, 2016

raffaelespazzoli commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

etsauer commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

raffaelespazzoli commented Oct 10, 2016

sabre1041 commented Oct 10, 2016

raffaelespazzoli commented Oct 11, 2016

sabre1041 commented Oct 13, 2016

sabre1041 commented Oct 13, 2016

sabre1041 Oct 6, 2016 •

edited

Loading

sabre1041 Oct 6, 2016 •

edited

Loading