Cert Management: Adding OCP v4 templates for use with OpenShift Applier #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @pabrahamsson |
|
/approve |
pabrahamsson
requested changes
Sep 3, 2020
There was a problem hiding this comment.
Looks good @oybed, should we make a mention somewhere that the AWS_SECRET_ACCESS_KEY needs to be base64 encoded? Alternatively we could use stringData in the secret.
|
/approve |
oybed
changed the title
pabrahamsson
approved these changes
Sep 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pabrahamsson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
Adding support for cert-manager / OCPv4 for use with openshift-applier
How do we test this?
Tweak the params, then run the openshift-applier with the inventory
cc: @redhat-cop/day-in-the-life