Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up README for IPA/IdM deployment #518

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Fixing up README for IPA/IdM deployment #518

merged 3 commits into from
Aug 5, 2021

Conversation

oybed
Copy link
Contributor

@oybed oybed commented Aug 5, 2021

What is this PR About?

The "params" section of the README wasn't rendering correctly. This PR makes it a table.

How do we test this?

N/A - doc change

cc: @redhat-cop/day-in-the-life

Copy link
Contributor

@springdo springdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@springdo
Copy link
Contributor

springdo commented Aug 5, 2021

/approve

@redhat-cop-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: springdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@springdo
Copy link
Contributor

springdo commented Aug 5, 2021

/lgtm

@springdo springdo removed the request for review from tylerauerbeck August 5, 2021 14:15
@redhat-cop-ci-bot redhat-cop-ci-bot merged commit ab0fba7 into redhat-cop:master Aug 5, 2021
pabrahamsson pushed a commit to pabrahamsson/containers-quickstarts that referenced this pull request Feb 14, 2022
* Fixing up IPA/IdM README

* Fixing up IPA/IdM README

* Fixing up IPA/IdM README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants