add validation for environment variables #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation in object.go for environment variables. Currently, the only validation that is being added is to check for the presence of "=" in either environment variable key or value, and if found, then error out. This is only going to validate the environment variables passed in the OpenCompose file, not as per Kubernetes validations, which should be added in kubernetes.go which is being tracked in redhat-developer#139
concaf
force-pushed
the
add_env_validation
branch
from
75657c7
to
fcae646
Compare
kadel
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds validation in object.go for environment variables.
Currently, the only validation that is being added is to check for
the presence of "=" in either environment variable key or value,
and if found, then error out.
This is only going to validate the environment variables passed in
the OpenCompose file, not as per Kubernetes validations, which
should be added in kubernetes.go which is being tracked in #139