Add ingress support #69
Conversation
|
@kadel please review this when you get a chance. The WIP is just because it's missing an update to reference doc. I'll fix it once we agree that the implementation is ok. |
pkg/encoding/v1/encoding.go
Outdated
|
|
||
| // TODO: Add Uri unmarshalling to validate it | ||
|
|
||
| type UriPath string |
There was a problem hiding this comment.
What is difference between Uri and UriPath ?
There was a problem hiding this comment.
Same question here.
Also calling it uri might be little bit misleading :(
There was a problem hiding this comment.
Also calling it uri might be little bit misleading :(
@kadel could you elaborate on this?
There was a problem hiding this comment.
I guess it should be named URN if that's what you meant
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run("", func(t *testing.T) { |
There was a problem hiding this comment.
I don't want to. Naming just for the sake of naming is wrong. Naming is hard and I would rather have unnamed test than those with misleading descriptions. Especially with the feature that if you specify empty string there and it fails, it will tell you the exact test index. good enough for me.
This feature is for generic naming when you can actually substitute the test case into some formatted string like fmt.Sprintf("%s in %s", tc.gmt, tc.loc) - not for structures taking 20 lines to initialize.
There was a problem hiding this comment.
how can a description that the test author write be misleading? since the test author has highest knowledge of what is happening.
There was a problem hiding this comment.
because naming is hard ;) (especially when it's suppose to make sense to others)
| result := []runtime.Object{} | ||
|
|
||
| i := &ext_v1beta1.Ingress{ | ||
| ObjectMeta: api_v1.ObjectMeta{ |
There was a problem hiding this comment.
Can we abstract this ObjectMeta ? Now it's used in 4 places already?
There was a problem hiding this comment.
Not really sure what you would like to get abstracted here. The object data are always different.
There was a problem hiding this comment.
I don't think there is anything to abstract there, it's just object initialization
|
Updated the confusing Uri and added ingress support to reference-file @kadel PTAL |
|
|
||
| Specifying host will make your application accessible outside of the cluster on domain specified as a value of `host`. (Note: this requires you to manually setup DNS records to point to your cluster's Ingress router. For development you can use services like http://nip.io/ or [http://xip.io/].) | ||
|
|
||
| #### path |
There was a problem hiding this comment.
I think we need a little bit more explanation what path does. Ideally with some examples.
|
@kadel I've added a description on path based routing to address #69 (comment) |
Closes #21